lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-07-01 22:54:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

[MSI] Fix not showing combobox items (#9165)

Browse Source 
Import fix from Wine-11.6, commit 46e5cabca7

msi: Add ComboBox items, using value if text does not exist.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56296

PR #8971 will upgrade module to Wine-10.0,
so guard the change with `#ifdef __REACTOS__`. Fixes CORE-15709.

Co-authored-by: Maotong Zhang <zmtong1988@gmail.com>
This commit is contained in:
Mohammad Amin Mollazadeh
2026-06-16 18:22:31 +03:30
committed by GitHub
parent 91146de1cd
commit ea313e6129
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dll/win32/msi/dialog.c
View File

@@ -1397,7 +1397,11 @@ static UINT combobox_add_item( MSIRECORD *rec, void *param )
info->items[info->addpos_items] = wcsdup( value );
#ifdef __REACTOS__ /* Import fix from Wine-11.6 */
pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)(text ? text : value) );
#else
pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)text );
#endif
SendMessageW( info->hwnd, CB_SETITEMDATA, pos, (LPARAM)info->items[info->addpos_items] );
info->addpos_items++;