From ea313e6129b979c39b866a264300a7e8c284684c Mon Sep 17 00:00:00 2001 From: Mohammad Amin Mollazadeh Date: Tue, 16 Jun 2026 18:22:31 +0330 Subject: [PATCH] [MSI] Fix not showing combobox items (#9165) Import fix from Wine-11.6, commit https://github.com/wine-mirror/wine/commit/46e5cabca7be1d09d561f6203f073a7bff385d5d msi: Add ComboBox items, using value if text does not exist. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56296 PR #8971 will upgrade module to Wine-10.0, so guard the change with `#ifdef __REACTOS__`. Fixes CORE-15709. Co-authored-by: Maotong Zhang --- dll/win32/msi/dialog.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dll/win32/msi/dialog.c b/dll/win32/msi/dialog.c index 9b72b1ed7cc..31dbe0e79c9 100644 --- a/dll/win32/msi/dialog.c +++ b/dll/win32/msi/dialog.c @@ -1397,7 +1397,11 @@ static UINT combobox_add_item( MSIRECORD *rec, void *param ) info->items[info->addpos_items] = wcsdup( value ); +#ifdef __REACTOS__ /* Import fix from Wine-11.6 */ + pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)(text ? text : value) ); +#else pos = SendMessageW( info->hwnd, CB_ADDSTRING, 0, (LPARAM)text ); +#endif SendMessageW( info->hwnd, CB_SETITEMDATA, pos, (LPARAM)info->items[info->addpos_items] ); info->addpos_items++;