mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
6770f1a148
## Problem
Adding a private SQL snippet ('user' visibility) as a Home / project
overview report created a broken experience for other project members,
who saw "SQL snippet not found" because they had no access to the
snippet.
## Fix
Selecting a private snippet from the report block picker now shows a
confirmation step that makes the snippet public to the project before it
is added. Already-shared snippets are added directly, and snippets
created via drag-and-drop onto the report are now shared on creation.
## How to test
- Open a project's homepage and go to the Reports section
- Create a private SQL snippet if you do not have one
- Click "Add block" and select the private snippet
- Confirm a dialog appears explaining the snippet will become visible to
the team
- Confirm, and verify the block is added to the report
- Log in as another project member and confirm the report block renders
instead of "SQL snippet not found"
- Selecting an already-shared snippet should add it without the
confirmation dialog
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Added a “make snippet public” confirmation flow for user-owned report
blocks.
* Updated snippet selection to support a private-snippet share prompt
when appropriate.
* **Bug Fixes**
* Improved duplicate-block handling to prevent adding the same snippet
multiple times.
* **Refactor**
* Refactored SQL snippet upsert payload construction for more consistent
project visibility updates.
* **Tests**
* Added unit tests covering snippet selection decision logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
13 lines
414 B
TypeScript
13 lines
414 B
TypeScript
import type { Content } from '@/data/content/content-query'
|
|
|
|
export type SnippetSelectionAction = 'already-added' | 'confirm-share' | 'add'
|
|
|
|
export function resolveSnippetSelection(
|
|
snippet: { visibility: Content['visibility'] },
|
|
isAlreadyInReport: boolean
|
|
): SnippetSelectionAction {
|
|
if (isAlreadyInReport) return 'already-added'
|
|
if (snippet.visibility === 'user') return 'confirm-share'
|
|
return 'add'
|
|
}
|