mirror of
https://github.com/supabase/supabase.git
synced 2026-09-09 11:30:17 +08:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
51 lines
1.5 KiB
TypeScript
51 lines
1.5 KiB
TypeScript
'use client'
|
|
|
|
import { setBlogViewCookie, type BlogView } from 'app/blog/blog-view'
|
|
import { motion } from 'framer-motion'
|
|
import { AlignJustify, Grid } from 'lucide-react'
|
|
import { cn } from 'ui'
|
|
|
|
export default function BlogViewToggle({
|
|
view,
|
|
setView,
|
|
}: {
|
|
view: BlogView
|
|
setView: (view: BlogView) => void
|
|
}) {
|
|
return (
|
|
<div className="flex items-center border border-border rounded-md p-0.5 gap-0.5 bg-surface-100">
|
|
{(['list', 'grid'] as BlogView[]).map((v) => (
|
|
<button
|
|
tabIndex={0}
|
|
key={v}
|
|
onClick={() => {
|
|
setView(v)
|
|
setBlogViewCookie(v)
|
|
}}
|
|
aria-label={`${v} view`}
|
|
aria-pressed={view === v}
|
|
className={cn(
|
|
'relative flex items-center justify-center w-7 h-7 rounded-sm transition-colors',
|
|
view === v ? 'text-foreground' : 'text-foreground-light hover:text-foreground'
|
|
)}
|
|
>
|
|
{view === v && (
|
|
<motion.span
|
|
layoutId="blog-view-bg"
|
|
className="absolute inset-0 rounded-sm bg-surface-300 border border-border"
|
|
transition={{ type: 'spring', duration: 0.3, bounce: 0.15 }}
|
|
/>
|
|
)}
|
|
<span className="relative z-10">
|
|
{v === 'list' ? (
|
|
<AlignJustify className="w-3.5 h-3.5" />
|
|
) : (
|
|
<Grid className="w-3.5 h-3.5" />
|
|
)}
|
|
</span>
|
|
</button>
|
|
))}
|
|
</div>
|
|
)
|
|
}
|