mirror of
https://github.com/supabase/supabase.git
synced 2026-09-09 03:19:36 +08:00
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Chore / build (ESLint config upgrade + lint cleanup). ## What is the current behavior? `eslint-plugin-react-hooks` v5 (pulled in transitively by `eslint-config-next` v15) doesn't recognize stable `useEffectEvent`, so every effect that calls an effect-event handler needs an `eslint-disable react-hooks/exhaustive-deps` to silence a false positive. There are 30 such dead disables across Studio. ## What is the new behavior? Bumps `eslint-config-next` to v16, which pulls in `eslint-plugin-react-hooks` v7 whose `exhaustive-deps` understands `useEffectEvent`, and removes the 30 now-dead disable directives (and their orphaned explanatory comments). Supporting changes: - **Flat-config migration**: v16 is a native flat-config array (v15 was eslintrc), so `eslint-config-supabase` now spreads it directly instead of bridging through `FlatCompat`. - **React Compiler rules off**: v16 enables react-hooks v7's `recommended`, which layers the React Compiler lint rules on top of the two classic rules. These are switched off (derived dynamically from what next enables) to keep this change scoped to the `exhaustive-deps` improvement. - **Plugin-registration fallout** (v16 scopes plugin registration to a file glob rather than registering globally like FlatCompat did): stop re-registering `@typescript-eslint` (shared) and `jsx-a11y` (studio); scope our react / react-hooks / jsx-a11y rule overrides (studio, www) to v16's plugin glob so they don't error on files outside it (e.g. `.cjs`). - **Lint surface preserved**: v16's glob newly includes `.mts`/`.cts` (v15 didn't lint them), which surfaced pre-existing errors in tooling scripts. The shared config keeps the prior surface by leaving `.mts`/`.cts` unlinted; linting them is left as a separate change. - **Ratchet**: rebaselines `@tanstack/query/exhaustive-deps` 9 → 89. v15 forced next's `@babel/eslint-parser` onto `.ts` files, hiding these deps; v16 parses `.ts` with `@typescript-eslint/parser` and correctly surfaces the intentional `connectionString`-excluded-from-`queryKey` pattern. Worth a follow-up to review whether any are real cache-correctness bugs. - Drops three now-dead devDeps from `eslint-config-supabase`: `@eslint/eslintrc`, `@eslint/js`, `@typescript-eslint/eslint-plugin`. Verified locally: `turbo run lint` → 7/7 packages pass with 0 errors; Studio `lint:ratchet` passes; Prettier clean on changed files; typecheck unaffected. ## Additional context <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Refined linting configuration and removed outdated lint suppressions across Studio. * Updated Next.js linting support and refreshed related development configuration. * Expanded lint baseline coverage for query-related code. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
265 lines
8.8 KiB
TypeScript
265 lines
8.8 KiB
TypeScript
import { useParams } from 'common'
|
|
import dayjs from 'dayjs'
|
|
import Link from 'next/link'
|
|
import { useMemo } from 'react'
|
|
import {
|
|
MetricCard,
|
|
MetricCardContent,
|
|
MetricCardHeader,
|
|
MetricCardLabel,
|
|
MetricCardValue,
|
|
} from 'ui-patterns/MetricCard'
|
|
|
|
import {
|
|
parseConnectionsData,
|
|
parseInfrastructureMetrics,
|
|
} from './DatabaseInfrastructureSection.utils'
|
|
import { useInfraMonitoringAttributesQuery } from '@/data/analytics/infra-monitoring-query'
|
|
import { useMaxConnectionsQuery } from '@/data/database/max-connections-query'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
|
|
type DatabaseInfrastructureSectionProps = {
|
|
interval: '1hr' | '1day' | '7day'
|
|
refreshKey: number
|
|
dbErrorRate: number
|
|
isLoading: boolean
|
|
slowQueriesCount?: number
|
|
slowQueriesLoading?: boolean
|
|
}
|
|
|
|
export const DatabaseInfrastructureSection = ({
|
|
interval,
|
|
refreshKey,
|
|
dbErrorRate: _dbErrorRate,
|
|
isLoading: _dbLoading,
|
|
slowQueriesCount = 0,
|
|
slowQueriesLoading = false,
|
|
}: DatabaseInfrastructureSectionProps) => {
|
|
const { ref: projectRef } = useParams()
|
|
const { data: project } = useSelectedProjectQuery()
|
|
|
|
// refreshKey forces date recalculation when user clicks refresh button
|
|
const { startDate, endDate, infraInterval } = useMemo(() => {
|
|
const now = dayjs()
|
|
const end = now.toISOString()
|
|
let start: string
|
|
let infraInterval: '1h' | '1d'
|
|
|
|
switch (interval) {
|
|
case '1hr':
|
|
start = now.subtract(1, 'hour').toISOString()
|
|
infraInterval = '1h'
|
|
break
|
|
case '1day':
|
|
start = now.subtract(1, 'day').toISOString()
|
|
infraInterval = '1h'
|
|
break
|
|
case '7day':
|
|
start = now.subtract(7, 'day').toISOString()
|
|
infraInterval = '1d'
|
|
break
|
|
default:
|
|
start = now.subtract(1, 'hour').toISOString()
|
|
infraInterval = '1h'
|
|
}
|
|
|
|
return { startDate: start, endDate: end, infraInterval }
|
|
}, [interval, refreshKey])
|
|
|
|
const {
|
|
data: infraData,
|
|
isLoading: infraLoading,
|
|
error: infraError,
|
|
} = useInfraMonitoringAttributesQuery({
|
|
projectRef,
|
|
attributes: [
|
|
'avg_cpu_usage',
|
|
'ram_usage',
|
|
'disk_fs_used_system',
|
|
'disk_fs_used_wal',
|
|
'pg_database_size',
|
|
'disk_fs_size',
|
|
'disk_io_consumption',
|
|
'pg_stat_database_num_backends',
|
|
],
|
|
startDate,
|
|
endDate,
|
|
interval: infraInterval,
|
|
})
|
|
|
|
const { data: maxConnectionsData } = useMaxConnectionsQuery({
|
|
projectRef,
|
|
connectionString: project?.connectionString,
|
|
})
|
|
|
|
const metrics = useMemo(() => parseInfrastructureMetrics(infraData), [infraData])
|
|
|
|
const connections = useMemo(
|
|
() => parseConnectionsData(infraData, maxConnectionsData),
|
|
[infraData, maxConnectionsData]
|
|
)
|
|
|
|
const errorMessage =
|
|
infraError && typeof infraError === 'object' && 'message' in infraError
|
|
? String(infraError.message)
|
|
: 'Error loading data'
|
|
|
|
// Generate database report URL with time range parameters
|
|
const getDatabaseReportUrl = () => {
|
|
const now = dayjs()
|
|
let its: string
|
|
let helperText: string
|
|
|
|
switch (interval) {
|
|
case '1hr':
|
|
its = now.subtract(1, 'hour').toISOString()
|
|
helperText = 'Last 60 minutes'
|
|
break
|
|
case '1day':
|
|
its = now.subtract(24, 'hour').toISOString()
|
|
helperText = 'Last 24 hours'
|
|
break
|
|
case '7day':
|
|
its = now.subtract(7, 'day').toISOString()
|
|
helperText = 'Last 7 days'
|
|
break
|
|
default:
|
|
its = now.subtract(24, 'hour').toISOString()
|
|
helperText = 'Last 24 hours'
|
|
}
|
|
|
|
const ite = now.toISOString()
|
|
const params = new URLSearchParams({
|
|
its,
|
|
ite,
|
|
isHelper: 'true',
|
|
helperText,
|
|
})
|
|
|
|
return `/project/${projectRef}/observability/database?${params.toString()}`
|
|
}
|
|
|
|
const databaseReportUrl = getDatabaseReportUrl()
|
|
|
|
return (
|
|
<div>
|
|
<h2 className="mb-4">Database</h2>
|
|
{/* First row: Metrics */}
|
|
<div className="grid grid-cols-3 gap-2">
|
|
<Link
|
|
href={`/project/${projectRef}/observability/query-performance?totalTimeFilter=${encodeURIComponent(JSON.stringify({ operator: '>', value: 1000 }))}`}
|
|
className="block group"
|
|
>
|
|
<MetricCard isLoading={slowQueriesLoading}>
|
|
<MetricCardHeader linkTooltip="Go to query performance">
|
|
<MetricCardLabel tooltip="Queries with total execution time (execution time + planning time) greater than 1000ms. High values may indicate query optimization opportunities">
|
|
Slow Queries
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
<MetricCardValue>{slowQueriesCount}</MetricCardValue>
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
|
|
<Link href={databaseReportUrl} className="block group">
|
|
<MetricCard isLoading={infraLoading}>
|
|
<MetricCardHeader linkTooltip="Go to database report">
|
|
<MetricCardLabel tooltip="Highest concurrent database connections observed in the selected window, against the connection limit. Monitor to avoid connection exhaustion.">
|
|
Peak Connections
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
{infraError ? (
|
|
<div className="text-xs text-destructive wrap-break-word">{errorMessage}</div>
|
|
) : connections.max > 0 ? (
|
|
<MetricCardValue>
|
|
{connections.peak}/{connections.max}
|
|
</MetricCardValue>
|
|
) : (
|
|
<MetricCardValue>--</MetricCardValue>
|
|
)}
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
|
|
<Link href={databaseReportUrl} className="block group">
|
|
<MetricCard isLoading={infraLoading}>
|
|
<MetricCardHeader linkTooltip="Go to database report">
|
|
<MetricCardLabel tooltip="Disk usage percentage of total disk space used">
|
|
Disk Usage
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
{infraError ? (
|
|
<div className="text-xs text-destructive wrap-break-word">{errorMessage}</div>
|
|
) : metrics ? (
|
|
<MetricCardValue>{metrics.disk.current.toFixed(0)}%</MetricCardValue>
|
|
) : (
|
|
<MetricCardValue>--</MetricCardValue>
|
|
)}
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
|
|
<Link href={databaseReportUrl} className="block group">
|
|
<MetricCard isLoading={infraLoading}>
|
|
<MetricCardHeader linkTooltip="Go to database report">
|
|
<MetricCardLabel tooltip="Disk I/O consumption percentage. High values may indicate disk bottlenecks">
|
|
Disk IO
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
{infraError ? (
|
|
<div className="text-xs text-destructive wrap-break-word">{errorMessage}</div>
|
|
) : metrics ? (
|
|
<MetricCardValue>{metrics.diskIo.current.toFixed(0)}%</MetricCardValue>
|
|
) : (
|
|
<MetricCardValue>--</MetricCardValue>
|
|
)}
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
|
|
<Link href={databaseReportUrl} className="block group">
|
|
<MetricCard isLoading={infraLoading}>
|
|
<MetricCardHeader linkTooltip="Go to database report">
|
|
<MetricCardLabel tooltip="RAM usage percentage. Sustained high usage may indicate memory pressure">
|
|
Memory
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
{infraError ? (
|
|
<div className="text-xs text-destructive wrap-break-word">{errorMessage}</div>
|
|
) : metrics ? (
|
|
<MetricCardValue>{metrics.ram.current.toFixed(0)}%</MetricCardValue>
|
|
) : (
|
|
<MetricCardValue>--</MetricCardValue>
|
|
)}
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
|
|
<Link href={databaseReportUrl} className="block group">
|
|
<MetricCard isLoading={infraLoading}>
|
|
<MetricCardHeader linkTooltip="Go to database report">
|
|
<MetricCardLabel tooltip="CPU usage percentage. High values may suggest CPU-intensive queries or workloads">
|
|
CPU
|
|
</MetricCardLabel>
|
|
</MetricCardHeader>
|
|
<MetricCardContent>
|
|
{infraError ? (
|
|
<div className="text-xs text-destructive wrap-break-word">{errorMessage}</div>
|
|
) : metrics ? (
|
|
<MetricCardValue>{metrics.cpu.current.toFixed(0)}%</MetricCardValue>
|
|
) : (
|
|
<MetricCardValue>--</MetricCardValue>
|
|
)}
|
|
</MetricCardContent>
|
|
</MetricCard>
|
|
</Link>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|