Hermès Bélusca-Maïto 2a5536c540 [CONSOLE.CPL] Rewrite the BuildCodePageList() registry enumeration loop and use far less stack space. ...

Any valid code page value name in System\CurrentControlSet\Control\Nls\CodePage
is a string representation of its corresponding decimal value, that
cannot be larger than MAXUSHORT == 65535, i.e. longer than 5+1
characters.

Noticed with the analyser warning
dll\cpl\console\options.c(74): warning C6262: Function uses '32808' bytes
of stack: exceeds /analyze:stacksize '16384'. Consider moving some data to heap.

Make the enumeration loop actually stop when ERROR_NO_MORE_ITEMS is
returned. If we got another error, e.g. because the value name was
too long (and thus, an invalid code page), just ignore and continue
looping.

2022-01-30 01:02:08 +01:00

14 KiB

Raw Blame History

View Raw