lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-06-04 02:10:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

[FASTFAT] Lock DirResource when modifying an entry on disk.

Browse Source 
Likely not optimal, but fixes some races conditions where
the directory is uninit in the middle of the write.
This commit is contained in:
Pierre Schweitzer
2018-05-26 17:12:03 +02:00
parent cca1a3f47f
commit fc788cf2fd
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/filesystems/fastfat/finfo.c
View File

@@ -1552,6 +1552,7 @@ VfatSetInformation(
PVFATFCB FCB;
NTSTATUS Status = STATUS_SUCCESS;
PVOID SystemBuffer;
BOOLEAN LockDir;
/* PRECONDITION */
ASSERT(IrpContext);
@@ -1593,7 +1594,14 @@ VfatSetInformation(
DPRINT("Can set file size\n");
}
if (FileInformationClass == FileRenameInformation)
LockDir = FALSE;
if (FileInformationClass == FileRenameInformation || FileInformationClass == FileAllocationInformation ||
FileInformationClass == FileEndOfFileInformation || FileInformationClass == FileBasicInformation)
{
LockDir = TRUE;
}
if (LockDir)
{
if (!ExAcquireResourceExclusiveLite(&((PDEVICE_EXTENSION)IrpContext->DeviceObject->DeviceExtension)->DirResource,
BooleanFlagOn(IrpContext->Flags, IRPCONTEXT_CANWAIT)))
@@ -1607,7 +1615,7 @@ VfatSetInformation(
if (!ExAcquireResourceExclusiveLite(&FCB->MainResource,
BooleanFlagOn(IrpContext->Flags, IRPCONTEXT_CANWAIT)))
{
if (FileInformationClass == FileRenameInformation)
if (LockDir)
{
ExReleaseResourceLite(&((PDEVICE_EXTENSION)IrpContext->DeviceObject->DeviceExtension)->DirResource);
}
@@ -1662,7 +1670,7 @@ VfatSetInformation(
ExReleaseResourceLite(&FCB->MainResource);
}
if (FileInformationClass == FileRenameInformation)
if (LockDir)
{
ExReleaseResourceLite(&((PDEVICE_EXTENSION)IrpContext->DeviceObject->DeviceExtension)->DirResource);
}