lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-06-02 01:11:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

[TASKMGR] Fix a handle leak of ReleaseDC (#8513)

Browse Source 
JIRA issue: CORE-20230

Fix a handle leak that forgot ReleaseDC(hParentWnd, hdc); on failure.
This commit is contained in:
Copilot
2025-12-21 08:12:57 +09:00
committed by GitHub
parent 8e952f1510
commit be39662767
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
base/applications/taskmgr/graphctl.c
View File

@@ -67,18 +67,15 @@ GraphCtrl_Create(PTM_GRAPH_CONTROL inst, HWND hWnd, HWND hParentWnd, PTM_FORMAT
inst->ftPixelsPerPercent = (FLOAT)(inst->BitmapHeight) / 100.00f;
hdc = GetDC(hParentWnd);
hdcg = CreateCompatibleDC(hdc);
inst->hdcGraph = hdcg;
inst->hbmGraph = CreateCompatibleBitmap(hdc, inst->BitmapWidth, inst->BitmapHeight);
if (!hdc ||
!hdcg ||
!inst->hbmGraph)
{
if (!hdc)
goto fail;
}
inst->hdcGraph = hdcg = CreateCompatibleDC(hdc);
inst->hbmGraph = CreateCompatibleBitmap(hdc, inst->BitmapWidth, inst->BitmapHeight);
ReleaseDC(hParentWnd, hdc);
if (!hdcg || !inst->hbmGraph)
goto fail;
hbmOld = (HBITMAP)SelectObject(hdcg, inst->hbmGraph);
DeleteObject(hbmOld);