lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-05-30 23:33:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

[WINETESTS] Workaround crashes in riched20:richole on VBox/KVM bots CORE-16799

Browse Source 
The crashes began when those tests were synced to Wine Staging 4.18 in
0.4.14-dev-419-g 76cf09cfea

WHS 2k3sp2 Before the revert implies the tests were actually ok:
https://reactos.org/testman/compare.php?ids=77492

Disabling some of the tests is very unsatisfying of course,
but at least allows us to observe again
the results of the other tests from that suite.

VBox https://reactos.org/testman/compare.php?ids=77504,77506
KVM https://reactos.org/testman/compare.php?ids=77502,77505
This commit is contained in:
Joachim Henze
2021-06-04 20:04:20 +02:00
parent 7f2e0ece5a
commit ae574e16f8
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/rostests/winetests/riched20/richole.c
View File

@@ -113,6 +113,7 @@ static ULONG get_refcount(IUnknown *iface)
return IUnknown_Release(iface);
}
#if 0 /*avoid CORE-16799*/
#define CHECK_TYPEINFO(disp,expected_riid) _check_typeinfo((IDispatch *)disp, expected_riid, __LINE__)
static void _check_typeinfo(IDispatch* disp, REFIID expected_riid, int line)
{
@@ -137,12 +138,15 @@ static void _check_typeinfo(IDispatch* disp, REFIID expected_riid, int line)
ITypeInfo_ReleaseTypeAttr(typeinfo, typeattr);
ITypeInfo_Release(typeinfo);
}
#endif
static void test_Interfaces(void)
{
IRichEditOle *reOle = NULL, *reOle1 = NULL;
ITextDocument *txtDoc = NULL;
#if 0 /*avoid CORE-16799*/
ITextDocument2Old *txtDoc2Old = NULL;
#endif
ITextSelection *txtSel = NULL, *txtSel2;
IUnknown *punk;
HRESULT hres;
@@ -170,7 +174,9 @@ static void test_Interfaces(void)
(void **) &txtDoc);
ok(hres == S_OK, "IRichEditOle_QueryInterface\n");
ok(txtDoc != NULL, "IRichEditOle_QueryInterface\n");
#if 0 /*avoid CORE-16799*/
CHECK_TYPEINFO(txtDoc, &IID_ITextDocument);
#endif
hres = ITextDocument_GetSelection(txtDoc, NULL);
ok(hres == E_INVALIDARG, "ITextDocument_GetSelection: 0x%x\n", hres);
@@ -222,6 +228,7 @@ static void test_Interfaces(void)
hres = IRichEditOle_QueryInterface(reOle, &IID_IOleInPlaceSite, (void **) &punk);
ok(hres == E_NOINTERFACE, "IRichEditOle_QueryInterface\n");
#if 0 /*avoid CORE-16799*/
hres = IRichEditOle_QueryInterface(reOle, &IID_ITextDocument2Old, (void **)&txtDoc2Old);
ok(hres == S_OK, "IRichEditOle_QueryInterface\n");
ok(txtDoc2Old != NULL, "IRichEditOle_QueryInterface\n");
@@ -231,6 +238,7 @@ static void test_Interfaces(void)
CHECK_TYPEINFO(txtDoc2Old, &IID_ITextDocument);
ITextDocument2Old_Release(txtDoc2Old);
#endif
ITextDocument_Release(txtDoc);
IRichEditOle_Release(reOle);
@@ -245,6 +253,7 @@ static void test_Interfaces(void)
ITextSelection_Release(txtSel);
#if 0 /*avoid CORE-16799*/
w = new_richedit(NULL);
res = SendMessageA(w, EM_GETOLEINTERFACE, 0, (LPARAM)&reOle);
ok(res, "SendMessage\n");
@@ -257,6 +266,7 @@ static void test_Interfaces(void)
ITextDocument2Old_Release(txtDoc2Old);
IRichEditOle_Release(reOle);
DestroyWindow(w);
#endif
}
static void test_ITextDocument_Open(void)