lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-05-30 23:33:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

[NTOS:IO] Don't call IopCompleteRequest with uninitialized context values. CID 716761

Browse Source 
NormalContext and NormalRoutine are just for good measure, but
SystemArgument2 is actually used by the function.
And yes, this appears to be a bug in Win 2003.
This commit is contained in:
Thomas Faber
2021-10-28 11:17:03 -04:00
parent 8254585be5
commit a74ff5be17
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ntoskrnl/io/iomgr/iofunc.c
View File

@@ -148,6 +148,8 @@ IopPerformSynchronousRequest(IN PDEVICE_OBJECT DeviceObject,
if (Status != STATUS_PENDING)
{
/* Complete it ourselves */
NormalRoutine = NULL;
NormalContext = NULL;
ASSERT(!Irp->PendingReturned);
KeRaiseIrql(APC_LEVEL, &OldIrql);
IopCompleteRequest(&Irp->Tail.Apc,
@@ -2640,6 +2642,8 @@ NtQueryInformationFile(IN HANDLE FileHandle,
Irp->UserIosb = IoStatusBlock;
/* The IRP wasn't completed, complete it ourselves */
NormalRoutine = NULL;
NormalContext = NULL;
KeRaiseIrql(APC_LEVEL, &OldIrql);
IopCompleteRequest(&Irp->Tail.Apc,
&NormalRoutine,
@@ -3480,6 +3484,8 @@ NtSetInformationFile(IN HANDLE FileHandle,
Irp->UserIosb = IoStatusBlock;
/* The IRP wasn't completed, complete it ourselves */
NormalRoutine = NULL;
NormalContext = NULL;
KeRaiseIrql(APC_LEVEL, &OldIrql);
IopCompleteRequest(&Irp->Tail.Apc,
&NormalRoutine,