lywsvip/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2026-05-24 00:00:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

[CMAKE] Fix invalid usage of list()

Browse Source 
list() functions expects numerical indices for modification operations
and silently converts everything else to a number (old behaviour).

CMake 3.21 now checks this and throws a warning
This commit is contained in:
Victor Perevertkin
2021-09-13 20:13:40 +03:00
parent 8e1fa03456
commit 4e389a992d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sdk/cmake/CMakeMacros.cmake
View File

@@ -287,10 +287,10 @@ function(add_cd_file)
endif()
# do we add it to all CDs?
list(FIND _CD_FOR all __cd)
list(FIND _CD_FOR "all" __cd)
if(NOT __cd EQUAL -1)
list(REMOVE_AT _CD_FOR __cd)
list(INSERT _CD_FOR __cd "bootcd;livecd;regtest")
list(REMOVE_ITEM _CD_FOR "all")
list(APPEND _CD_FOR "bootcd;livecd;regtest")
endif()
# do we add it to bootcd?