lywsvip/orris
1
0
Fork 0
mirror of https://github.com/orris-inc/orris.git synced 2026-05-06 21:44:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: skip address/port uniqueness check when node address is empty

Browse Source 
Align admin node update with the other three node usecases: an empty
server address is a placeholder and must not participate in
(address, port) uniqueness, otherwise two placeholder nodes sharing a
port would wrongly collide on save.
This commit is contained in:
orris-inc
2026-04-23 16:22:47 +08:00
parent eb4772c10e
commit 6a571b88ab
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/application/node/usecases/updatenode.go
View File

@@ -186,8 +186,9 @@ func (uc *UpdateNodeUseCase) Execute(ctx context.Context, cmd UpdateNodeCommand)
if cmd.AgentPort != nil {
newPort = int(*cmd.AgentPort)
}
// Only check if address or port actually changed
if newAddress != existingNode.ServerAddress().Value() || newPort != int(existingNode.AgentPort()) {
// Only check when address is non-empty and address or port actually changed.
// An empty address is treated as a placeholder and must not participate in (address, port) uniqueness.
if newAddress != "" && (newAddress != existingNode.ServerAddress().Value() || newPort != int(existingNode.AgentPort())) {
exists, err := uc.nodeRepo.ExistsByAddressExcluding(ctx, newAddress, newPort, existingNode.ID())
if err != nil {
uc.logger.Errorw("failed to check address uniqueness", "error", err, "address", newAddress, "port", newPort)