fix: remove support for deleteApp

With session elevation this would require re-authentication, and this is
to much effort to implement for just one function that's probably only
rarely used.
This commit is contained in:
Jannis Mattheis
2026-04-19 20:20:44 +02:00
parent b02254110d
commit 2fb1e06eef
2 changed files with 3 additions and 21 deletions

View File

@@ -41,15 +41,12 @@ import com.github.gotify.Utils
import com.github.gotify.Utils.launchCoroutine
import com.github.gotify.api.Api
import com.github.gotify.api.ApiException
import com.github.gotify.api.Callback
import com.github.gotify.api.ClientFactory
import com.github.gotify.client.ApiClient
import com.github.gotify.client.api.ApplicationApi
import com.github.gotify.client.api.AuthApi
import com.github.gotify.client.api.ClientApi
import com.github.gotify.client.api.MessageApi
import com.github.gotify.client.model.Application
import com.github.gotify.client.model.Client
import com.github.gotify.client.model.Message
import com.github.gotify.databinding.ActivityMessagesBinding
import com.github.gotify.init.InitializationActivity
@@ -540,28 +537,13 @@ internal class MessagesActivity :
if (item.itemId == R.id.action_delete_app) {
MaterialAlertDialogBuilder(this)
.setTitle(R.string.delete_app)
.setMessage(R.string.ack)
.setPositiveButton(R.string.yes) { _, _ -> deleteApp(viewModel.appId) }
.setNegativeButton(R.string.no, null)
.setMessage(R.string.delete_app_not_supported)
.setPositiveButton(android.R.string.ok, null)
.show()
}
return super.onContextItemSelected(item)
}
private fun deleteApp(appId: Long) {
val settings = viewModel.settings
val client = ClientFactory.clientToken(settings)
client.createService(ApplicationApi::class.java)
.deleteApp(appId)
.enqueue(
Callback.callInUI(
this,
onSuccess = { refreshAll() },
onError = { Utils.showSnackBar(this, getString(R.string.error_delete_app)) }
)
)
}
private suspend fun loadMore(appId: Long): List<MessageWithImage> {
val messagesWithImages = viewModel.messages.loadMore(appId)
withContext(Dispatchers.Main) {

View File

@@ -25,7 +25,7 @@
<string name="grouped_message">Received %d messages while being disconnected</string>
<string name="delete_all">Delete all messages</string>
<string name="delete_app">Delete application</string>
<string name="error_delete_app">Could not delete this app</string>
<string name="delete_app_not_supported">Deleting applications is not currently supported. Use the WebUI.</string>
<string name="delete_logs">Delete logs</string>
<string name="copy_logs">Copy logs</string>
<string name="logs_copied">Logs copied</string>