Merge pull request #5821 from Hmbown/devin/1788325219-green-main

fix: make main green — macOS OAuth callback read + dead-code budget receipt
This commit is contained in:
Hunter Bown
2026-09-01 23:10:39 -07:00
committed by GitHub
2 changed files with 8 additions and 2 deletions

View File

@@ -495,6 +495,11 @@ fn wait_for_callback(listeners: &[TcpListener], expected_state: &str) -> Result<
}
fn handle_callback_stream(mut stream: TcpStream, expected_state: &str) -> Result<String> {
// BSD sockets (macOS) hand the accepted stream the listener's O_NONBLOCK;
// the bounded read below needs a blocking socket with a timeout.
stream
.set_nonblocking(false)
.context("ChatGPT OAuth callback stream could not be set blocking")?;
stream.set_read_timeout(Some(Duration::from_secs(5))).ok();
// One read is not one request: TCP may deliver the callback in
// fragments, and a truncated query parses as a missing parameter.

View File

@@ -1,9 +1,10 @@
{
"_comment": "Ceiling for `#[allow(dead_code)]` across crates/. This number may go down freely; raising it needs a reviewer to say why in the PR. Regenerate with: python3 scripts/check-dead-code-budget.py --update",
"_issue": "https://github.com/Hmbown/CodeWhale/issues/4785",
"total": 416,
"total": 425,
"per_crate": {
"app-server": 1,
"tools": 2,
"tui": 414
"tui": 422
}
}