lywsvip/CLIProxyAPI
1
0
Fork 0
mirror of https://github.com/router-for-me/CLIProxyAPI.git synced 2026-09-11 14:47:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): skip access logging for health probes

Browse Source
This commit is contained in:
chaoshou
2026-09-08 18:41:38 +08:00
parent 20e3f731ea
commit e026cbf4e9
2 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/api/server_routes.go
View File

@@ -48,8 +48,8 @@ func (s *Server) setupRoutes() {
c.JSON(http.StatusOK, gin.H{"status": "ok"})
}
s.engine.GET("/healthz", healthzHandler)
s.engine.HEAD("/healthz", healthzHandler)
s.engine.GET("/healthz", logging.SkipGinRequestLogging, healthzHandler)
s.engine.HEAD("/healthz", logging.SkipGinRequestLogging, healthzHandler)
s.engine.GET("/management.html", s.serveManagementControlPanel)
openaiHandlers := openai.NewOpenAIAPIHandler(s.handlers)

44
internal/api/server_test.go
View File

@@ -32,6 +32,8 @@ import (
coreusage "github.com/router-for-me/CLIProxyAPI/v7/sdk/cliproxy/usage"
sdkconfig "github.com/router-for-me/CLIProxyAPI/v7/sdk/config"
"github.com/router-for-me/CLIProxyAPI/v7/sdk/pluginapi"
log "github.com/sirupsen/logrus"
logtest "github.com/sirupsen/logrus/hooks/test"
"gopkg.in/yaml.v3"
)
@@ -666,6 +668,48 @@ func TestHealthz(t *testing.T) {
})
}
func TestHealthzSkipsAccessLogging(t *testing.T) {
server := newTestServer(t)
logger := log.StandardLogger()
previousHooks := logger.ReplaceHooks(make(log.LevelHooks))
previousLevel := logger.GetLevel()
hook := logtest.NewLocal(logger)
logger.SetLevel(log.InfoLevel)
t.Cleanup(func() {
logger.ReplaceHooks(previousHooks)
logger.SetLevel(previousLevel)
})
for _, method := range []string{http.MethodGet, http.MethodHead} {
t.Run(method, func(t *testing.T) {
hook.Reset()
recorder := httptest.NewRecorder()
server.engine.ServeHTTP(recorder, httptest.NewRequest(method, "/healthz", nil))
if recorder.Code != http.StatusOK {
t.Fatalf("health probe status = %d, want 200", recorder.Code)
}
for _, entry := range hook.AllEntries() {
if _, isAccessLog := entry.Data["request_id"]; isAccessLog && strings.Contains(entry.Message, `"/healthz"`) {
t.Errorf("health probe emitted an access log: %s", entry.Message)
}
}
hook.Reset()
ordinary := httptest.NewRecorder()
server.engine.ServeHTTP(ordinary, httptest.NewRequest(http.MethodGet, "/healthz-access-log-control", nil))
if ordinary.Code != http.StatusNotFound {
t.Fatalf("control status = %d, want 404", ordinary.Code)
}
for _, entry := range hook.AllEntries() {
if _, isAccessLog := entry.Data["request_id"]; isAccessLog && strings.Contains(entry.Message, `"/healthz-access-log-control"`) {
return
}
}
t.Error("ordinary request did not emit an access log after health probe")
})
}
}
func TestCodexLiveRoutesRequireAuthAndAreRegistered(t *testing.T) {
server := newTestServer(t)