lywsvip/CLIProxyAPI
1
0
Fork 0
mirror of https://github.com/router-for-me/CLIProxyAPI.git synced 2026-09-06 16:15:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(translator): rename system_instruction to systemInstruction for consistency

Browse Source 
Closes: #4583
This commit is contained in:
Luis Pater
2026-07-28 03:44:05 +08:00
parent 20f83cae91
commit cade44b9cd
2 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/translator/gemini/claude/gemini_claude_request.go
View File

@@ -55,10 +55,10 @@ func ConvertClaudeRequestToGemini(modelName string, inputRawJSON []byte, _ bool)
if len(systemParts) > 0 {
systemInstruction := []byte(`{"role":"user","parts":[]}`)
systemInstruction, _ = sjson.SetRawBytes(systemInstruction, "parts", translatorcommon.JoinRawArray(systemParts))
out, _ = sjson.SetRawBytes(out, "system_instruction", systemInstruction)
out, _ = sjson.SetRawBytes(out, "systemInstruction", systemInstruction)
}
} else if systemResult.Type == gjson.String && !util.IsClaudeCodeAttributionSystemText(systemResult.String()) {
out, _ = sjson.SetBytes(out, "system_instruction.parts.-1.text", systemResult.String())
out, _ = sjson.SetBytes(out, "systemInstruction.parts.-1.text", systemResult.String())
}
// contents

29
internal/translator/gemini/claude/gemini_claude_request_test.go
View File

@@ -41,6 +41,23 @@ func TestConvertClaudeRequestToGemini_ToolChoice_SpecificTool(t *testing.T) {
}
}
func TestConvertClaudeRequestToGemini_StringSystemInstruction(t *testing.T) {
inputJSON := []byte(`{
"model": "gemini-3-flash-preview",
"system": "Be concise",
"messages": [{"role": "user", "content": "Hello"}]
}`)
output := ConvertClaudeRequestToGemini("gemini-3-flash-preview", inputJSON, false)
if got := gjson.GetBytes(output, "systemInstruction.parts.0.text").String(); got != "Be concise" {
t.Fatalf("Expected systemInstruction text %q, got %q", "Be concise", got)
}
if gjson.GetBytes(output, "system_instruction").Exists() {
t.Fatalf("Legacy system_instruction field should not be emitted: %s", output)
}
}
func TestConvertClaudeRequestToGemini_ImageContent(t *testing.T) {
inputJSON := []byte(`{
"model": "gemini-3-flash-preview",
@@ -92,9 +109,9 @@ func TestConvertClaudeRequestToGemini_StripsClaudeCodeAttribution(t *testing.T)
output := ConvertClaudeRequestToGemini("gemini-3-flash-preview", inputJSON, false)
parts := gjson.GetBytes(output, "system_instruction.parts").Array()
parts := gjson.GetBytes(output, "systemInstruction.parts").Array()
if len(parts) != 2 {
t.Fatalf("Expected 2 system parts after attribution strip, got %d: %s", len(parts), gjson.GetBytes(output, "system_instruction.parts").Raw)
t.Fatalf("Expected 2 system parts after attribution strip, got %d: %s", len(parts), gjson.GetBytes(output, "systemInstruction.parts").Raw)
}
if got := parts[0].Get("text").String(); got != "You are a Claude agent, built on Anthropic's Claude Agent SDK." {
t.Fatalf("Unexpected first system part: %q", got)
@@ -102,8 +119,8 @@ func TestConvertClaudeRequestToGemini_StripsClaudeCodeAttribution(t *testing.T)
if got := parts[1].Get("text").String(); got != "User system prompt" {
t.Fatalf("Unexpected second system part: %q", got)
}
if gjson.GetBytes(output, `system_instruction.parts.#(text%"x-anthropic-billing-header:*")`).Exists() {
t.Fatalf("Claude Code attribution block was forwarded: %s", gjson.GetBytes(output, "system_instruction.parts").Raw)
if gjson.GetBytes(output, `systemInstruction.parts.#(text%"x-anthropic-billing-header:*")`).Exists() {
t.Fatalf("Claude Code attribution block was forwarded: %s", gjson.GetBytes(output, "systemInstruction.parts").Raw)
}
}
@@ -144,9 +161,9 @@ func TestConvertClaudeRequestToGemini_ConvertsMessageSystemRoleToUserContent(t *
t.Fatalf("Unexpected array message-level system content text: %q", got)
}
parts := gjson.GetBytes(output, "system_instruction.parts").Array()
parts := gjson.GetBytes(output, "systemInstruction.parts").Array()
if len(parts) != 1 {
t.Fatalf("Expected only top-level system parts, got %d: %s", len(parts), gjson.GetBytes(output, "system_instruction.parts").Raw)
t.Fatalf("Expected only top-level system parts, got %d: %s", len(parts), gjson.GetBytes(output, "systemInstruction.parts").Raw)
}
if got := parts[0].Get("text").String(); got != "Top-level rules" {
t.Fatalf("Unexpected first system part: %q", got)