lywsvip/warp
1
0
Fork 0
mirror of https://github.com/warpdotdev/warp.git synced 2026-05-06 23:32:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid parallel precheck execution (#10188)

Browse Source 
## Description
We were running three steps in parallel with `futures::join!`
1. Check binary
2. Check old binary for autoupdate
3. Detect platform

This will end up using 3 control master connections. Since each
connection is a limited resource, this could cause these open failed
issues.

For now I am moving these to be sequential. I considered combining them
into one command and have some client side parsing to reconstruct the
results but I am not confident about that change with different shells
and potential error states. We could observe if latency with sequential
execution becomes a problem and decide if we want to further optimize
This commit is contained in:
Yunfan Yang
2026-05-05 17:42:40 -04:00
committed by GitHub
parent 6a3da8b95a
commit 0f28bcb333
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
crates/remote_server/src/manager.rs
View File

@@ -484,16 +484,16 @@ impl RemoteServerManager {
ctx.background_executor()
.spawn(async move {
// Run platform detection, binary check, and old-binary
// check concurrently. The old-binary check lets the
// controller distinguish fresh install (no prior
// versioned binary) from update (prior versioned
// binary present), so it can skip the install prompt
// in the update case.
let (platform_result, check_result, old_binary_result) = futures::join!(
transport.detect_platform(),
transport.check_binary(),
transport.check_has_old_binary(),
);
// check sequentially so that each step reuses the
// same SSH ControlMaster connection instead of
// opening parallel channels. The old-binary check
// lets the controller distinguish fresh install (no
// prior versioned binary) from update (prior
// versioned binary present), so it can skip the
// install prompt in the update case.
let platform_result = transport.detect_platform().await;
let check_result = transport.check_binary().await;
let old_binary_result = transport.check_has_old_binary().await;
let platform = match platform_result {
Ok(p) => Some(p),
Err(e) => {