mirror of
https://github.com/supabase/supabase.git
synced 2026-05-20 04:23:53 +08:00
## Context Resolves FE-3126 Just cleaning up the table editor header with a bit of refactors (pre-req to investigating collapsing filter bar and table editor header actions into a single row) ## Non-visual changes involved - Break down components within `GridHeaderActions` into smaller ones - `IndexAdvisorPopover` - `SecurityDefinerViewPopover` - `RealtimeToggle` - Deprecate use of `useUrlState` in `GridHeaderActions` to use `useQueryState` instead - Improve types for `TwoOptionToggle` ## Visual changes involved - Collapse realtime button toggle into a button icon, with no text (just tooltip) - Adjust layout of buttons a little ### Before <img width="796" height="118" alt="image" src="https://github.com/user-attachments/assets/436bca94-4d91-471a-a184-487c6f78dc04" /> ### After <img width="731" height="132" alt="image" src="https://github.com/user-attachments/assets/5fd30982-a1fc-4f92-a590-146d1e69d52a" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Index Advisor popover with recommendations. * Realtime toggle to manage realtime table publication. * Security Definer view popover with optional autofix. * Insert menu for adding rows/columns and CSV import. * **Bug Fixes** * Adjusted filter bar input sizing for improved readability. * **Refactor** * Header layout updated and insert/import actions moved into dedicated components. * **Tests** * Updated end-to-end selectors for the Insert row menu item. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
109 lines
3.6 KiB
TypeScript
109 lines
3.6 KiB
TypeScript
import { useQueryClient } from '@tanstack/react-query'
|
|
import { toast } from 'sonner'
|
|
import { ScrollArea } from 'ui'
|
|
import { ConfirmationModal } from 'ui-patterns/Dialogs/ConfirmationModal'
|
|
import { GenericSkeletonLoader } from 'ui-patterns/ShimmeringLoader'
|
|
import { SimpleCodeBlock } from 'ui-patterns/SimpleCodeBlock'
|
|
|
|
import { useViewDefinitionQuery } from '@/data/database/view-definition-query'
|
|
import { lintKeys } from '@/data/lint/keys'
|
|
import { useExecuteSqlMutation } from '@/data/sql/execute-sql-mutation'
|
|
import { Entity, isViewLike } from '@/data/table-editor/table-editor-types'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
|
|
interface ViewEntityAutofixSecurityModalProps {
|
|
table: Entity
|
|
isAutofixViewSecurityModalOpen: boolean
|
|
setIsAutofixViewSecurityModalOpen: (isAutofixViewSecurityModalOpen: boolean) => void
|
|
}
|
|
|
|
export const ViewEntityAutofixSecurityModal = ({
|
|
table,
|
|
isAutofixViewSecurityModalOpen,
|
|
setIsAutofixViewSecurityModalOpen,
|
|
}: ViewEntityAutofixSecurityModalProps) => {
|
|
const { data: project } = useSelectedProjectQuery()
|
|
const queryClient = useQueryClient()
|
|
const {
|
|
isSuccess,
|
|
isPending: isLoading,
|
|
data,
|
|
} = useViewDefinitionQuery(
|
|
{
|
|
id: table?.id,
|
|
projectRef: project?.ref,
|
|
connectionString: project?.connectionString,
|
|
},
|
|
{
|
|
enabled: isAutofixViewSecurityModalOpen && isViewLike(table),
|
|
}
|
|
)
|
|
|
|
const { mutate: execute } = useExecuteSqlMutation({
|
|
onSuccess: async () => {
|
|
toast.success('View security changed successfully')
|
|
setIsAutofixViewSecurityModalOpen(false)
|
|
await queryClient.invalidateQueries({ queryKey: lintKeys.lint(project?.ref) })
|
|
},
|
|
onError: (error) => {
|
|
toast.error(`Failed to autofix view security: ${error.message}`)
|
|
},
|
|
})
|
|
|
|
function handleConfirm() {
|
|
const sql = `
|
|
ALTER VIEW "${table.schema}"."${table.name}" SET (security_invoker = on);
|
|
`
|
|
execute({
|
|
projectRef: project?.ref,
|
|
connectionString: project?.connectionString,
|
|
sql,
|
|
})
|
|
}
|
|
|
|
if (!isViewLike(table)) {
|
|
return null
|
|
}
|
|
|
|
return (
|
|
<ConfirmationModal
|
|
visible={isAutofixViewSecurityModalOpen}
|
|
size="xlarge"
|
|
title="Confirm autofixing view security"
|
|
confirmLabel="Confirm"
|
|
onCancel={() => setIsAutofixViewSecurityModalOpen(false)}
|
|
onConfirm={() => handleConfirm()}
|
|
>
|
|
<p className="text-sm text-foreground-light">
|
|
Setting <code>security_invoker=on</code> ensures the View runs with the permissions of the
|
|
querying user, reducing the risk of unintended data exposure.
|
|
</p>
|
|
<div className="flex items-center gap-8 mt-8">
|
|
<div className=" border rounded-md w-1/2">
|
|
<div className="p-4 pb-0 bg-200 font-mono text-sm font-semibold">Existing query</div>
|
|
<ScrollArea className="h-[225px] px-4 py-2">
|
|
{isLoading && <GenericSkeletonLoader />}
|
|
{isSuccess && (
|
|
<SimpleCodeBlock>
|
|
{`create view ${table.schema}.${table.name} as\n ${data}`}
|
|
</SimpleCodeBlock>
|
|
)}
|
|
</ScrollArea>
|
|
</div>
|
|
|
|
<div className=" border rounded-md w-1/2">
|
|
<div className="p-4 pb-0 bg-200 font-mono text-sm font-semibold">Updated query</div>
|
|
<ScrollArea className="h-[225px] px-4 py-2">
|
|
{isLoading && <GenericSkeletonLoader />}
|
|
{isSuccess && (
|
|
<SimpleCodeBlock>
|
|
{`create view ${table.schema}.${table.name} with (security_invoker = on) as\n ${data}`}
|
|
</SimpleCodeBlock>
|
|
)}
|
|
</ScrollArea>
|
|
</div>
|
|
</div>
|
|
</ConfirmationModal>
|
|
)
|
|
}
|