mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
57 lines
1.7 KiB
TypeScript
57 lines
1.7 KiB
TypeScript
import { useParams } from 'common'
|
|
import { Unlock } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Button, Popover, PopoverContent, PopoverTrigger } from 'ui'
|
|
|
|
import { type Lint } from '@/data/lint/lint-query'
|
|
|
|
export const SecurityDefinerViewPopover = ({
|
|
lint,
|
|
onAutofix,
|
|
}: {
|
|
lint: Lint | null
|
|
onAutofix?: () => void
|
|
}) => {
|
|
const { ref } = useParams()
|
|
|
|
return (
|
|
<Popover modal={false}>
|
|
<PopoverTrigger asChild>
|
|
<Button variant="warning" icon={<Unlock strokeWidth={1.5} />}>
|
|
Security Definer view
|
|
</Button>
|
|
</PopoverTrigger>
|
|
<PopoverContent className="min-w-[395px] text-sm" align="end">
|
|
<h4 className="flex items-center gap-2">
|
|
<Unlock size={14} /> Secure your view
|
|
</h4>
|
|
<div className="grid gap-2 mt-2 text-foreground-light text-sm">
|
|
<p>
|
|
This view is defined with the Security Definer property, giving it permissions of the
|
|
view's creator (Postgres), rather than the permissions of the querying user.
|
|
</p>
|
|
|
|
<p>Since this view is in the public schema, it is accessible via your project's APIs.</p>
|
|
|
|
<div className="mt-2 flex items-center gap-2">
|
|
{!!onAutofix && (
|
|
<Button variant="secondary" onClick={onAutofix}>
|
|
Autofix
|
|
</Button>
|
|
)}
|
|
<Button variant="default" asChild>
|
|
<Link
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
href={`/project/${ref}/advisors/security?preset=${lint?.level}&id=${lint?.cache_key}`}
|
|
>
|
|
Learn more
|
|
</Link>
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</PopoverContent>
|
|
</Popover>
|
|
)
|
|
}
|