Files
supabase/apps/studio/components/interfaces/TableGridEditor/GridHeaderActions.tsx
ChloeGarciaMillerand cea246d195 Fix: improve accessibility for icon buttons (Table Editor menu) (#47639)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Bug fix (accessibility improvement)

## What is the current behavior?

Icon-only buttons do not have explicit accessible names for screen
readers or tooltips.

## What is the new behavior?

All icon-only buttons now have explicit accessible names using visually
hidden text (sr-only), ensuring proper screen reader support.

## Additional context

Tooltip text is preserved or added for visual users.
No visual changes were introduced.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Accessibility Improvements**
* Updated table editor action controls with clearer, context-aware
`aria-label`s (e.g., “Add new column”, “More options for …”, “New
table”).
* **UI Refinements**
* Added hover tooltips to key table editor actions, including
add-column, more-options dropdown triggers, and create-new-table button,
improving discoverability and guidance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-07-24 10:47:14 +02:00

409 lines
15 KiB
TypeScript

import { PermissionAction } from '@supabase/shared-types/out/constants'
import { Realtime } from 'icons'
import { BookOpenText, Lightbulb, Lock, MoreVertical, PlusCircle, Unlock } from 'lucide-react'
import Link from 'next/link'
import { parseAsBoolean, useQueryState } from 'nuqs'
import { useState } from 'react'
import { toast } from 'sonner'
import {
Button,
cn,
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuSeparator,
DropdownMenuTrigger,
Popover,
PopoverContent,
PopoverTrigger,
Tooltip,
TooltipContent,
TooltipTrigger,
} from 'ui'
import { EnableIndexAdvisorDialog } from '../QueryPerformance/IndexAdvisor/EnableIndexAdvisorButton'
import { RoleImpersonationPopover } from '../RoleImpersonationSelector/RoleImpersonationPopover'
import { InsertButton } from './InsertButton'
import { RealtimeToggleDialog } from './RealtimeToggleDialog'
import { SecurityDefinerViewPopover } from './SecurityDefinerViewPopover'
import { ViewEntityAutofixSecurityModal } from './ViewEntityAutofixSecurityModal'
import { RefreshButton } from '@/components/grid/components/header/RefreshButton'
import { useTableIndexAdvisor } from '@/components/grid/context/TableIndexAdvisorContext'
import { RLSToggleDialog } from '@/components/interfaces/Database/RLSToggleDialog'
import {
getEntityLintDetails,
getTablePoliciesUrl,
} from '@/components/interfaces/TableGridEditor/TableEntity.utils'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import { useDatabasePoliciesQuery } from '@/data/database-policies/database-policies-query'
import { useIsTableRealtimeEnabled } from '@/data/database-publications/database-publications-query'
import { useProjectLintsQuery } from '@/data/lint/lint-query'
import {
Entity,
isTableLike,
isForeignTable as isTableLikeForeignTable,
isMaterializedView as isTableLikeMaterializedView,
isView as isTableLikeView,
} from '@/data/table-editor/table-editor-types'
import { useTableUpdateMutation } from '@/data/tables/table-update-mutation'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
import { useIsFeatureEnabled } from '@/hooks/misc/useIsFeatureEnabled'
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
import { useIsProtectedSchema } from '@/hooks/useProtectedSchemas'
import { DOCS_URL } from '@/lib/constants'
import { useTrack } from '@/lib/telemetry/track'
import { useAppStateSnapshot } from '@/state/app-state'
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
export interface GridHeaderActionsProps {
table: Entity
isRefetching: boolean
}
export const GridHeaderActions = ({ table, isRefetching }: GridHeaderActionsProps) => {
const track = useTrack()
const appSnap = useAppStateSnapshot()
const snap = useTableEditorTableStateSnapshot()
const { data: project } = useSelectedProjectQuery()
const [rlsConfirmModalOpen, setRlsConfirmModalOpen] = useState(false)
const [realtimeDialogOpen, setRealtimeDialogOpen] = useState(false)
const [indexAdvisorDialogOpen, setIndexAdvisorDialogOpen] = useState(false)
const [isAutofixViewSecurityModalOpen, setIsAutofixViewSecurityModalOpen] = useState(false)
const [showWarning, setShowWarning] = useQueryState(
'showWarning',
parseAsBoolean.withDefault(false)
)
// need project lints to get security status for views
const { data: lints = [] } = useProjectLintsQuery({ projectRef: project?.ref })
// Use table-specific index advisor context
const { isAvailable: isIndexAdvisorAvailable, isEnabled: isIndexAdvisorEnabled } =
useTableIndexAdvisor()
const isTable = isTableLike(table)
const isForeignTable = isTableLikeForeignTable(table)
const isView = isTableLikeView(table)
const isMaterializedView = isTableLikeMaterializedView(table)
const { realtimeAll: realtimeEnabled } = useIsFeatureEnabled(['realtime:all'])
const { isSchemaLocked } = useIsProtectedSchema({ schema: table.schema })
const isRealtimeEnabled = useIsTableRealtimeEnabled({ id: table.id })
const { mutateAsync: updateTable, isPending: isUpdatingTable } = useTableUpdateMutation({
onError: (error) => {
toast.error(`Failed to toggle RLS: ${error.message}`)
},
})
const showHeaderActions = snap.selectedRows.size === 0
const projectRef = project?.ref
const { data } = useDatabasePoliciesQuery(
{
projectRef: project?.ref,
connectionString: project?.connectionString,
schemas: [table.schema],
},
{ enabled: !!table }
)
const policies = (data ?? []).filter(
(policy) => policy.schema === table.schema && policy.table === table.name
)
const { can: canSqlWriteTables, isLoading: isLoadingPermissions } = useAsyncCheckPermissions(
PermissionAction.TENANT_SQL_ADMIN_WRITE,
'tables'
)
const { can: canSqlWriteColumns } = useAsyncCheckPermissions(
PermissionAction.TENANT_SQL_ADMIN_WRITE,
'columns'
)
const isReadOnly = !isLoadingPermissions && !canSqlWriteTables && !canSqlWriteColumns
// This will change when we allow autogenerated API docs for schemas other than `public`
const doesHaveAutoGeneratedAPIDocs = table.schema === 'public'
const { hasLint: tableHasLints } = getEntityLintDetails(
table.name,
'rls_disabled_in_public',
['ERROR'],
lints,
table.schema
)
const { hasLint: viewHasLints, matchingLint: matchingViewLint } = getEntityLintDetails(
table.name,
'security_definer_view',
['ERROR', 'WARN'],
lints,
table.schema
)
const { hasLint: materializedViewHasLints, matchingLint: matchingMaterializedViewLint } =
getEntityLintDetails(
table.name,
'materialized_view_in_api',
['ERROR', 'WARN'],
lints,
table.schema
)
const onViewAPIDocs = () => {
appSnap.setActiveDocsSection(['entities', table.name])
appSnap.setShowProjectApiDocs(true)
track('api_docs_opened', { source: 'table_editor' })
}
const onToggleRLS = async () => {
const payload = {
id: table.id,
rls_enabled: !(isTable && table.rls_enabled),
}
const updateTablePromise = updateTable({
projectRef: project?.ref!,
connectionString: project?.connectionString,
id: table.id,
name: table.name,
schema: table.schema,
payload: payload,
})
track('table_rls_enabled', {
method: 'table_editor',
schema_name: table.schema,
table_name: table.name,
})
return updateTablePromise
}
return (
<div className="flex items-center space-x-2">
{showHeaderActions && (
<div className="flex items-center gap-x-2">
{isReadOnly && (
<Tooltip>
<TooltipTrigger asChild>
<div className="border border-strong rounded-sm bg-overlay-hover px-3 py-1 text-xs">
Viewing as read-only
</div>
</TooltipTrigger>
<TooltipContent side="bottom">
You need additional permissions to manage your project's data
</TooltipContent>
</Tooltip>
)}
{isTable && !isSchemaLocked ? (
table.rls_enabled ? (
<>
{policies.length < 1 && !isSchemaLocked ? (
<ButtonTooltip
asChild
variant="default"
className="group"
icon={<PlusCircle strokeWidth={1.5} className="text-foreground-muted" />}
tooltip={{
content: {
side: 'bottom',
className: 'w-[280px]',
text: 'RLS is enabled for this table, but no policies are set. Select queries may return 0 results.',
},
}}
>
<Link passHref href={getTablePoliciesUrl(projectRef, table.schema, table.name)}>
Add RLS policy
</Link>
</ButtonTooltip>
) : (
<Button
asChild
variant={policies.length < 1 && !isSchemaLocked ? 'warning' : 'default'}
className="group"
icon={
isSchemaLocked || policies.length > 0 ? (
<div
className={cn(
'flex items-center justify-center rounded-full bg-border-stronger h-[16px]',
policies.length > 9 ? ' px-1' : 'w-[16px]',
''
)}
>
<span className="text-[11px] text-foreground font-mono text-center">
{policies.length}
</span>
</div>
) : (
<PlusCircle strokeWidth={1.5} />
)
}
>
<Link passHref href={getTablePoliciesUrl(projectRef, table.schema, table.name)}>
RLS {policies.length > 1 ? 'policies' : 'policy'}
</Link>
</Button>
)}
</>
) : tableHasLints ? (
<Popover modal={false} open={showWarning} onOpenChange={setShowWarning}>
<PopoverTrigger asChild>
<Button variant="danger" icon={<Lock strokeWidth={1.5} />}>
RLS disabled
</Button>
</PopoverTrigger>
<PopoverContent className="w-80 text-sm" align="end">
<h4 className="flex items-center gap-2">
<Lock size={16} /> Row Level Security (RLS)
</h4>
<div className="grid gap-2 mt-4 text-foreground-light text-xs">
<p>
You can restrict and control who can read, write and update data in this table
using Row Level Security.
</p>
<p>
With RLS enabled, anonymous users will not be able to read/write data in the
table.
</p>
{!isSchemaLocked && (
<Button
variant="default"
className="mt-2 w-min"
onClick={() => setRlsConfirmModalOpen(!rlsConfirmModalOpen)}
>
Enable RLS for this table
</Button>
)}
</div>
</PopoverContent>
</Popover>
) : null
) : null}
{isView && viewHasLints && (
<SecurityDefinerViewPopover
lint={matchingViewLint}
onAutofix={() => {
setIsAutofixViewSecurityModalOpen(true)
}}
/>
)}
{isMaterializedView && materializedViewHasLints && (
<SecurityDefinerViewPopover lint={matchingMaterializedViewLint} />
)}
{isForeignTable && table.schema === 'public' && (
<Popover modal={false} open={showWarning} onOpenChange={setShowWarning}>
<PopoverTrigger asChild>
<Button variant="warning" icon={<Unlock strokeWidth={1.5} />}>
Unprotected Data API access
</Button>
</PopoverTrigger>
<PopoverContent className="min-w-[395px] text-sm" align="end">
<h3 className="flex items-center gap-2">
<Unlock size={16} /> Secure Foreign table
</h3>
<div className="grid gap-2 mt-4 text-foreground-light text-sm">
<p>
Foreign tables do not enforce RLS, which may allow unrestricted access. To
secure them, either move foreign tables to a private schema not exposed by
PostgREST, or <a href="">disable PostgREST access</a> entirely.
</p>
<div className="mt-2">
<Button variant="default" asChild>
<Link
target="_blank"
href={`${DOCS_URL}/guides/database/extensions/wrappers/overview#security`}
>
Learn more
</Link>
</Button>
</div>
</div>
</PopoverContent>
</Popover>
)}
<RoleImpersonationPopover header="View data as a role" align="center" />
<DropdownMenu>
<Tooltip>
<TooltipTrigger asChild>
<DropdownMenuTrigger asChild>
<Button
variant="default"
icon={<MoreVertical />}
className="h-7 w-7"
aria-label={`More options for ${table.name}`}
/>
</DropdownMenuTrigger>
</TooltipTrigger>
<TooltipContent side="bottom">More options</TooltipContent>
</Tooltip>
<DropdownMenuContent className="w-48">
{isTable && realtimeEnabled && (
<DropdownMenuItem className="gap-x-2" onClick={() => setRealtimeDialogOpen(true)}>
<Realtime size={14} className={isRealtimeEnabled ? 'text-brand' : ''} />
<span>{isRealtimeEnabled ? 'Disable' : 'Enable'} Realtime</span>
</DropdownMenuItem>
)}
{doesHaveAutoGeneratedAPIDocs && (
<DropdownMenuItem className="gap-x-2" onClick={() => onViewAPIDocs()}>
<BookOpenText size={14} />
<span>View API docs</span>
</DropdownMenuItem>
)}
{isTable && isIndexAdvisorAvailable && !isIndexAdvisorEnabled && (
<>
<DropdownMenuSeparator />
<DropdownMenuItem
className="gap-x-2"
onClick={() => setIndexAdvisorDialogOpen(true)}
>
<Lightbulb size={14} />
<span>Enable Index Advisor</span>
</DropdownMenuItem>
</>
)}
</DropdownMenuContent>
</DropdownMenu>
<RefreshButton tableId={table.id} isRefetching={isRefetching} />
{showHeaderActions && <InsertButton />}
</div>
)}
<ViewEntityAutofixSecurityModal
table={table}
isAutofixViewSecurityModalOpen={isAutofixViewSecurityModalOpen}
setIsAutofixViewSecurityModalOpen={setIsAutofixViewSecurityModalOpen}
/>
{isTable && (
<RLSToggleDialog
open={rlsConfirmModalOpen}
tableName={table.name}
isEnabled={table.rls_enabled}
isSubmitting={isUpdatingTable}
onOpenChange={setRlsConfirmModalOpen}
onConfirm={onToggleRLS}
/>
)}
<RealtimeToggleDialog
table={table}
open={realtimeDialogOpen}
setOpen={setRealtimeDialogOpen}
/>
<EnableIndexAdvisorDialog open={indexAdvisorDialogOpen} setOpen={setIndexAdvisorDialogOpen} />
</div>
)
}