mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
40 lines
990 B
TypeScript
40 lines
990 B
TypeScript
import type { MouseEventHandler } from 'react'
|
|
// End of third-party imports
|
|
|
|
import { Button, cn } from 'ui'
|
|
|
|
interface SubmitButtonProps {
|
|
isSubmitting: boolean
|
|
userEmail: string
|
|
onClick?: MouseEventHandler<HTMLButtonElement>
|
|
className?: string
|
|
descriptionClassName?: string
|
|
}
|
|
|
|
export function SubmitButton({
|
|
isSubmitting,
|
|
userEmail,
|
|
onClick,
|
|
className,
|
|
descriptionClassName,
|
|
}: SubmitButtonProps) {
|
|
return (
|
|
<div className={cn('flex flex-col gap-3', className)}>
|
|
<Button
|
|
type="submit"
|
|
size="small"
|
|
block
|
|
disabled={isSubmitting}
|
|
loading={isSubmitting}
|
|
onClick={onClick}
|
|
>
|
|
Send support request
|
|
</Button>
|
|
<p className={cn('text-xs text-foreground-lighter text-balance pr-4', descriptionClassName)}>
|
|
We will contact you at <span className="text-foreground font-medium">{userEmail}</span>.
|
|
Please ensure emails from supabase.com are allowed.
|
|
</p>
|
|
</div>
|
|
)
|
|
}
|