mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
178 lines
6.0 KiB
TypeScript
178 lines
6.0 KiB
TypeScript
import { zodResolver } from '@hookform/resolvers/zod'
|
||
import { useParams } from 'common'
|
||
import { Eye, EyeOff } from 'lucide-react'
|
||
import { useEffect, useState } from 'react'
|
||
import { SubmitHandler, useForm } from 'react-hook-form'
|
||
import { useLatest } from 'react-use'
|
||
import { toast } from 'sonner'
|
||
import {
|
||
Button,
|
||
Form,
|
||
FormControl,
|
||
FormField,
|
||
Input,
|
||
Sheet,
|
||
SheetContent,
|
||
SheetFooter,
|
||
SheetHeader,
|
||
SheetSection,
|
||
SheetTitle,
|
||
Textarea,
|
||
} from 'ui'
|
||
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
|
||
import z from 'zod'
|
||
|
||
import { DiscardChangesConfirmationDialog } from '@/components/ui-patterns/Dialogs/DiscardChangesConfirmationDialog'
|
||
import { useSecretsCreateMutation } from '@/data/secrets/secrets-create-mutation'
|
||
import { ProjectSecret } from '@/data/secrets/secrets-query'
|
||
import { useConfirmOnClose } from '@/hooks/ui/useConfirmOnClose'
|
||
|
||
const FORM_ID = 'edit-secret-sidepanel'
|
||
|
||
const FormSchema = z.object({
|
||
name: z.string().min(1, 'Please provide a name for your secret'),
|
||
value: z.string().min(1, 'Please provide a value for your secret'),
|
||
})
|
||
|
||
type FormSchemaType = z.infer<typeof FormSchema>
|
||
|
||
interface EditSecretSheetProps {
|
||
secret?: ProjectSecret
|
||
visible: boolean
|
||
onClose: () => void
|
||
}
|
||
|
||
export function EditSecretSheet({ secret, visible, onClose }: EditSecretSheetProps) {
|
||
const { ref: projectRef } = useParams()
|
||
const secretName = useLatest(secret?.name)
|
||
const [showSecretValue, setShowSecretValue] = useState(false)
|
||
|
||
const form = useForm<FormSchemaType>({
|
||
resolver: zodResolver(FormSchema),
|
||
})
|
||
|
||
const isValid = form.formState.isValid
|
||
const isDirty = form.formState.isDirty
|
||
|
||
const { mutate: updateSecret, isPending: isUpdating } = useSecretsCreateMutation({
|
||
onSuccess: (_, variables) => {
|
||
toast.success(`Successfully updated secret "${variables.secrets[0].name}"`)
|
||
onClose()
|
||
},
|
||
})
|
||
const onSubmit: SubmitHandler<FormSchemaType> = async ({ name, value }) => {
|
||
updateSecret({
|
||
projectRef,
|
||
secrets: [{ name, value }],
|
||
})
|
||
}
|
||
|
||
const { confirmOnClose, handleOpenChange, modalProps } = useConfirmOnClose({
|
||
checkIsDirty: () => isDirty,
|
||
onClose,
|
||
})
|
||
|
||
useEffect(() => {
|
||
if (visible) {
|
||
form.reset({ name: secretName.current ?? '', value: '' })
|
||
}
|
||
}, [form, secretName, visible])
|
||
|
||
return (
|
||
<Sheet open={visible} onOpenChange={handleOpenChange}>
|
||
<SheetContent size="default" className={'min-w-screen! lg:min-w-[600px]! flex flex-col'}>
|
||
<SheetHeader className="py-3 flex flex-row gap-3 items-center">
|
||
<SheetTitle>Edit secret</SheetTitle>
|
||
</SheetHeader>
|
||
|
||
<SheetSection className="h-full">
|
||
<Form {...form}>
|
||
<form
|
||
id={FORM_ID}
|
||
className="flex flex-col gap-y-4"
|
||
onSubmit={form.handleSubmit(onSubmit)}
|
||
>
|
||
<FormField
|
||
control={form.control}
|
||
name="name"
|
||
render={({ field }) => (
|
||
<FormItemLayout label="Name" layout="horizontal">
|
||
<FormControl>
|
||
<Input
|
||
{...field}
|
||
readOnly
|
||
className="text-foreground-light! cursor-not-allowed"
|
||
/>
|
||
</FormControl>
|
||
</FormItemLayout>
|
||
)}
|
||
/>
|
||
<FormField
|
||
control={form.control}
|
||
name="value"
|
||
render={({ field }) => (
|
||
<FormItemLayout
|
||
label="Value"
|
||
layout="horizontal"
|
||
description="Secrets can’t be retrieved once saved. Enter a new value to overwrite the existing value."
|
||
>
|
||
<FormControl>
|
||
<div className="relative">
|
||
<Textarea
|
||
{...field}
|
||
rows={1}
|
||
ref={(el) => {
|
||
field.ref(el)
|
||
if (el) {
|
||
el.style.height = 'auto'
|
||
el.style.height = Math.max(40, el.scrollHeight) + 'px'
|
||
}
|
||
}}
|
||
placeholder="my-secret-value"
|
||
data-1p-ignore
|
||
data-lpignore="true"
|
||
data-form-type="other"
|
||
data-bwignore
|
||
className="min-h-0 resize-none"
|
||
style={
|
||
{
|
||
WebkitTextSecurity: showSecretValue ? undefined : 'disc',
|
||
} as React.CSSProperties
|
||
}
|
||
onChange={(e) => {
|
||
field.onChange(e)
|
||
e.currentTarget.style.height = 'auto'
|
||
e.currentTarget.style.height =
|
||
Math.max(40, e.currentTarget.scrollHeight) + 'px'
|
||
}}
|
||
/>
|
||
<Button
|
||
variant="text"
|
||
className="absolute right-1 top-1 px-1"
|
||
icon={showSecretValue ? <EyeOff /> : <Eye />}
|
||
onClick={() => setShowSecretValue(!showSecretValue)}
|
||
/>
|
||
</div>
|
||
</FormControl>
|
||
</FormItemLayout>
|
||
)}
|
||
/>
|
||
</form>
|
||
</Form>
|
||
</SheetSection>
|
||
|
||
<SheetFooter>
|
||
<Button disabled={isUpdating} variant="default" onClick={confirmOnClose}>
|
||
Cancel
|
||
</Button>
|
||
<Button form={FORM_ID} type="submit" disabled={!isValid} loading={isUpdating}>
|
||
Save
|
||
</Button>
|
||
</SheetFooter>
|
||
</SheetContent>
|
||
|
||
<DiscardChangesConfirmationDialog {...modalProps} />
|
||
</Sheet>
|
||
)
|
||
}
|