mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
89 lines
2.9 KiB
TypeScript
89 lines
2.9 KiB
TypeScript
import { ArrowDownNarrowWide, ArrowDownWideNarrow } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuRadioGroup,
|
|
DropdownMenuRadioItem,
|
|
DropdownMenuSub,
|
|
DropdownMenuSubContent,
|
|
DropdownMenuSubTrigger,
|
|
DropdownMenuTrigger,
|
|
} from 'ui'
|
|
|
|
export const EDGE_FUNCTIONS_SORT_VALUES = [
|
|
'name:asc',
|
|
'name:desc',
|
|
'created_at:asc',
|
|
'created_at:desc',
|
|
'updated_at:asc',
|
|
'updated_at:desc',
|
|
] as const
|
|
|
|
export type EdgeFunctionsSort = (typeof EDGE_FUNCTIONS_SORT_VALUES)[number]
|
|
export type EdgeFunctionsSortColumn = EdgeFunctionsSort extends `${infer Column}:${string}`
|
|
? Column
|
|
: unknown
|
|
export type EdgeFunctionsSortOrder = EdgeFunctionsSort extends `${string}:${infer Order}`
|
|
? Order
|
|
: unknown
|
|
|
|
interface EdgeFunctionsSortDropdownProps {
|
|
value: EdgeFunctionsSort
|
|
onChange: (value: EdgeFunctionsSort) => void
|
|
}
|
|
|
|
function getSortLabel(value: EdgeFunctionsSort) {
|
|
const [sortCol] = value.split(':')
|
|
return sortCol.replace('_', ' ')
|
|
}
|
|
|
|
export const EdgeFunctionsSortDropdown = ({ value, onChange }: EdgeFunctionsSortDropdownProps) => {
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
variant="default"
|
|
icon={
|
|
value.includes('desc') ? (
|
|
<ArrowDownWideNarrow size={14} />
|
|
) : (
|
|
<ArrowDownNarrowWide size={14} />
|
|
)
|
|
}
|
|
>
|
|
Sorted by {getSortLabel(value)}
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="start" className="w-48">
|
|
<DropdownMenuRadioGroup
|
|
value={value}
|
|
onValueChange={(val) => onChange(val as EdgeFunctionsSort)}
|
|
>
|
|
<DropdownMenuSub>
|
|
<DropdownMenuSubTrigger>Sort by name</DropdownMenuSubTrigger>
|
|
<DropdownMenuSubContent>
|
|
<DropdownMenuRadioItem value="name:asc">Ascending</DropdownMenuRadioItem>
|
|
<DropdownMenuRadioItem value="name:desc">Descending</DropdownMenuRadioItem>
|
|
</DropdownMenuSubContent>
|
|
</DropdownMenuSub>
|
|
<DropdownMenuSub>
|
|
<DropdownMenuSubTrigger>Sort by created at</DropdownMenuSubTrigger>
|
|
<DropdownMenuSubContent>
|
|
<DropdownMenuRadioItem value="created_at:asc">Ascending</DropdownMenuRadioItem>
|
|
<DropdownMenuRadioItem value="created_at:desc">Descending</DropdownMenuRadioItem>
|
|
</DropdownMenuSubContent>
|
|
</DropdownMenuSub>
|
|
<DropdownMenuSub>
|
|
<DropdownMenuSubTrigger>Sort by updated at</DropdownMenuSubTrigger>
|
|
<DropdownMenuSubContent>
|
|
<DropdownMenuRadioItem value="updated_at:asc">Ascending</DropdownMenuRadioItem>
|
|
<DropdownMenuRadioItem value="updated_at:desc">Descending</DropdownMenuRadioItem>
|
|
</DropdownMenuSubContent>
|
|
</DropdownMenuSub>
|
|
</DropdownMenuRadioGroup>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)
|
|
}
|