mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
## Problem The "last used" indicator for the legacy `anon` / `service_role` API keys (Project API keys settings) was disabled because it ran a BigQuery `edge_logs` query. It is now re-enabled against the ClickHouse-backed `api_keys.last_used.otel` analytics endpoint. ## Current behavior - The `anon` / `service_role` "last used" indicator is off (the BigQuery-backed query was disabled). ## New behavior - New `useApiKeysLastUsedQuery` hook calls the `api_keys.last_used.otel` endpoint (timestamp params only, no SQL sent), plus its query key and the generated platform API type. - `DisplayApiSettings` reads last-used from this hook instead of posting BigQuery `edge_logs` SQL. The pure `getLastUsedAPIKeys` shaper is kept and unit-tested. Still gated by the `showApiKeysLastUsed` flag. - Removed the disabled secret-keys (`sb_secret_`) BigQuery last-used path, which has no ClickHouse endpoint to migrate to: drops the dead `useLastSeen` query, the `APIKeyRow` "Last Used" column, and the unused `showLastSeen` prop. - Reworded the delete-confirmation copy to be accurate for both secret and publishable keys. ## Additional context - Backed by the platform endpoint in supabase/platform#34892 (merged and deployed). - Scope: `anon` / `service_role` legacy keys. Secret/publishable and JWT signing-key "last used" are follow-ups, pending the endpoint returning those key types. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Updated API key settings to show “last used” activity for the past 24 hours using a dedicated data source and time window. * Added clearer messaging when recent API key activity fails to load. * Removed the “Last Used” column from API key management tables. * **Bug Fixes** * Improved mapping so “last used” values correctly match the intended key and role. * Updated API key deletion confirmation to explain required backend changes and resulting unauthorized behavior. * **Tests** * Added unit tests to validate “last used” computation and edge-case filtering. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
106 lines
3.3 KiB
TypeScript
106 lines
3.3 KiB
TypeScript
import { IS_PLATFORM } from 'common'
|
|
import { motion } from 'framer-motion'
|
|
import { MoreVertical } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuTrigger,
|
|
TableCell,
|
|
TableRow,
|
|
} from 'ui'
|
|
|
|
import { APIKeyDeleteDialog } from './APIKeyDeleteDialog'
|
|
import { ApiKeyPill } from './ApiKeyPill'
|
|
import { TextConfirmModal } from '@/components/ui/TextConfirmModalWrapper'
|
|
import type { APIKeysData } from '@/data/api-keys/api-keys-query'
|
|
|
|
export const APIKeyRow = ({
|
|
apiKey,
|
|
isDeleting,
|
|
isDeleteModalOpen,
|
|
onDelete,
|
|
setKeyToDelete,
|
|
}: {
|
|
apiKey: Extract<APIKeysData[number], { type: 'secret' | 'publishable' }>
|
|
isDeleting: boolean
|
|
isDeleteModalOpen: boolean
|
|
onDelete: () => void
|
|
setKeyToDelete: (id: string | null) => void
|
|
}) => {
|
|
const MotionTableRow = motion.create(TableRow)
|
|
|
|
return (
|
|
<>
|
|
<MotionTableRow
|
|
layout
|
|
initial={{ opacity: 0, height: 0 }}
|
|
animate={{ opacity: 1, height: 'auto' }}
|
|
exit={{ opacity: 0, height: 0 }}
|
|
transition={{
|
|
type: 'spring',
|
|
stiffness: 500,
|
|
damping: 50,
|
|
mass: 1,
|
|
}}
|
|
>
|
|
<TableCell className="py-2 w-56">
|
|
<div className="flex flex-col">
|
|
<span className="font-medium">{apiKey.name}</span>
|
|
<div className="text-sm text-foreground-lighter">
|
|
{apiKey.description || <span className="text-foreground-muted">No description</span>}
|
|
</div>
|
|
</div>
|
|
</TableCell>
|
|
|
|
<TableCell className="py-2">
|
|
<div className="flex flex-row gap-2">
|
|
<ApiKeyPill apiKey={apiKey} />
|
|
</div>
|
|
</TableCell>
|
|
|
|
{IS_PLATFORM && (
|
|
<TableCell className="py-2">
|
|
<div className="flex justify-end">
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger className="px-1 focus-visible:outline-hidden" asChild>
|
|
<Button
|
|
variant="text"
|
|
size="tiny"
|
|
icon={
|
|
<MoreVertical
|
|
size="14"
|
|
className="text-foreground-light hover:text-foreground"
|
|
/>
|
|
}
|
|
/>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent className="max-w-40" align="end">
|
|
<APIKeyDeleteDialog apiKey={apiKey} setKeyToDelete={setKeyToDelete} />
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
</div>
|
|
</TableCell>
|
|
)}
|
|
</MotionTableRow>
|
|
|
|
<TextConfirmModal
|
|
visible={isDeleteModalOpen}
|
|
onCancel={() => setKeyToDelete(null)}
|
|
onConfirm={onDelete}
|
|
title={`Delete ${apiKey.type} API key: ${apiKey.name}`}
|
|
confirmString={apiKey.name}
|
|
confirmLabel="Yes, irreversibly delete this API key"
|
|
confirmPlaceholder="Type the name of the API key to confirm"
|
|
loading={isDeleting}
|
|
variant="destructive"
|
|
alert={{
|
|
title: 'This cannot be undone',
|
|
description:
|
|
'Make sure all applications and services using it have been updated before deletion. Deletion will cause them to receive HTTP 401 Unauthorized status codes on all Supabase APIs.',
|
|
}}
|
|
/>
|
|
</>
|
|
)
|
|
}
|