mirror of
https://github.com/supabase/supabase.git
synced 2026-09-06 18:11:51 +08:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
92 lines
3.3 KiB
TypeScript
92 lines
3.3 KiB
TypeScript
'use client'
|
|
|
|
import { safeHistoryReplaceState } from '~/lib/historyUtils'
|
|
import { useEffect, useReducer, useRef } from 'react'
|
|
import { Dialog, DialogContent, DialogHeader, DialogSection, Heading } from 'ui'
|
|
import { IconPanel } from 'ui-patterns/IconPanel'
|
|
|
|
import { PhoneLoginsItems } from '../Navigation/NavigationMenu/NavigationMenu.constants'
|
|
import MessageBird from './MessageBirdConfig.mdx'
|
|
import TextLocal from './TextLocalConfig.mdx'
|
|
import Twilio from './TwilioConfig.mdx'
|
|
import Vonage from './VonageConfig.mdx'
|
|
|
|
const reducer = (_, action: (typeof PhoneLoginsItems)[number] | undefined) => {
|
|
const url = new URL(document.location.href)
|
|
if (action) {
|
|
url.searchParams.set('showSmsProvider', encodeURIComponent(action.name))
|
|
} else {
|
|
url.searchParams.delete('showSmsProvider')
|
|
}
|
|
safeHistoryReplaceState(url.toString())
|
|
return action
|
|
}
|
|
|
|
const AuthSmsProviderConfig = () => {
|
|
const [selectedProvider, setSelectedProvider] = useReducer(reducer, undefined)
|
|
|
|
useEffect(() => {
|
|
const providerName = new URLSearchParams(document.location.search ?? '').get('showSmsProvider')
|
|
if (!providerName) return
|
|
|
|
const provider = PhoneLoginsItems.find((item) => item.name === decodeURIComponent(providerName))
|
|
if (provider) setSelectedProvider(provider)
|
|
}, [])
|
|
|
|
const headingRef = useRef<HTMLHeadingElement>(null)
|
|
|
|
return (
|
|
<>
|
|
<section aria-labelledby="sms-provider-configuration">
|
|
<h3 className="sr-only" id="sms-provider-configuration">
|
|
Configuring SMS Providers
|
|
</h3>
|
|
<div className="grid grid-cols-6 gap-10 not-prose py-8">
|
|
{PhoneLoginsItems.map((provider) => (
|
|
<button
|
|
tabIndex={0}
|
|
key={provider.name}
|
|
className="col-span-6 xl:col-span-3"
|
|
onClick={() => setSelectedProvider(provider)}
|
|
>
|
|
<IconPanel
|
|
title={provider.name}
|
|
icon={provider.icon}
|
|
hasLightIcon={provider.hasLightIcon}
|
|
/>
|
|
</button>
|
|
))}
|
|
</div>
|
|
</section>
|
|
<Dialog
|
|
open={!!selectedProvider}
|
|
onOpenChange={(open) => !open && setSelectedProvider(undefined)}
|
|
>
|
|
{selectedProvider && (
|
|
<DialogContent
|
|
className="w-[min(90vw,80ch)]! max-w-[min(90vw,80ch)]! max-h-[90dvh]! prose overflow-auto"
|
|
onOpenAutoFocus={(evt) => {
|
|
evt.preventDefault()
|
|
headingRef.current?.focus()
|
|
}}
|
|
>
|
|
<DialogHeader className="pb-0 [&>h3]:m-0! [&>h3>a]:hidden! [&>h3:focus-visible]:outline-hidden">
|
|
<Heading tag="h3" ref={headingRef} tabIndex={-1}>
|
|
{selectedProvider.name}
|
|
</Heading>
|
|
</DialogHeader>
|
|
<DialogSection className="*:first:mt-0">
|
|
{selectedProvider.name.toLowerCase().includes('messagebird') && <MessageBird />}
|
|
{selectedProvider.name.toLowerCase().includes('twilio') && <Twilio />}
|
|
{selectedProvider.name.toLowerCase().includes('vonage') && <Vonage />}
|
|
{selectedProvider.name.toLowerCase().includes('textlocal') && <TextLocal />}
|
|
</DialogSection>
|
|
</DialogContent>
|
|
)}
|
|
</Dialog>
|
|
</>
|
|
)
|
|
}
|
|
|
|
export default AuthSmsProviderConfig
|