mirror of
https://github.com/supabase/supabase.git
synced 2026-06-20 12:22:15 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
50 lines
1.3 KiB
TypeScript
50 lines
1.3 KiB
TypeScript
import { Button } from 'ui'
|
|
|
|
interface Props {
|
|
form: React.HTMLProps<HTMLButtonElement>['form']
|
|
hasChanges: boolean | undefined // Disables submit button if false
|
|
handleReset: () => void // Handling a reset/cancel of the form
|
|
helper?: React.ReactNode // Helper text to show alongside actions
|
|
disabled?: boolean
|
|
isSubmitting?: boolean
|
|
submitText?: string
|
|
}
|
|
|
|
export const FormActions = ({
|
|
form,
|
|
hasChanges = undefined,
|
|
handleReset,
|
|
helper,
|
|
disabled = false,
|
|
isSubmitting,
|
|
submitText = 'Save',
|
|
}: Props) => {
|
|
const isDisabled = isSubmitting || disabled || (!hasChanges && hasChanges !== undefined)
|
|
|
|
return (
|
|
<div
|
|
className={[
|
|
'flex w-full items-center gap-2',
|
|
// justify actions to right if no helper text
|
|
helper ? 'justify-between' : 'justify-end',
|
|
].join(' ')}
|
|
>
|
|
{helper && <span className="text-sm text-foreground-lighter">{helper}</span>}
|
|
<div className="flex items-center gap-2">
|
|
<Button disabled={isDisabled} variant="default" type="reset" onClick={() => handleReset()}>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
form={form}
|
|
variant="primary"
|
|
type="submit"
|
|
disabled={isDisabled}
|
|
loading={isSubmitting}
|
|
>
|
|
{submitText}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|