Files
supabase/apps/studio/components/interfaces/Functions/EdgeFunctionSecrets/EdgeFunctionSecrets.tsx
Jordi Enric b885b69bff feat(studio): restore workers secrets page FE-4280 (#49762)
## Problem

Workers Secrets was merged in #49589 into the stacked
jordi/workers-detail branch. The parent Workers PR reached master
without that child merge, leaving the page absent from staging.

## Fix

Cherry-pick the missing Workers Secrets route, menu item, shared-secret
copy, and generated route tree onto current master. The page uses the
existing workers flag and permission gates.

## How to test

- Enable the workers flag for a project with Workers access.
- Open Workers, then select Secrets.
- Expected result: the shared project secrets page renders at
/project/:ref/workers/secrets and is not treated as a worker named
secrets.
- Add, edit, or delete a secret, then confirm the same value appears
under Edge Functions, Secrets.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Added a **Secrets** page to the Workers section.
  * Added navigation to Worker secrets from the Workers menu.
* Displayed default secrets and deployment-specific guidance where
applicable.
* Clarified that platform secrets are shared between Edge Functions and
Workers.
  * Updated deletion warnings to reflect shared secret usage.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-31 19:17:39 +00:00

251 lines
9.5 KiB
TypeScript

import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useFlag, useParams } from 'common'
import { Search } from 'lucide-react'
import { parseAsString, useQueryState } from 'nuqs'
import { useEffect, useMemo, useState } from 'react'
import { toast } from 'sonner'
import { Badge, Card, Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from 'ui'
import { Input } from 'ui-patterns/DataInputs/Input'
import { ConfirmationModal } from 'ui-patterns/Dialogs/ConfirmationModal'
import { GenericSkeletonLoader } from 'ui-patterns/ShimmeringLoader'
import { AddNewSecretForm } from './AddNewSecretForm'
import { DefaultEdgeFunctionSecrets } from './DefaultEdgeFunctionSecrets'
import {
getVisibleDefaultEdgeFunctionSecrets,
isInternalEdgeFunctionSecret,
} from './DefaultEdgeFunctionSecrets.utils'
import EdgeFunctionSecret from './EdgeFunctionSecret'
import { EditSecretSheet } from './EditSecretSheet'
import { AlertError } from '@/components/ui/AlertError'
import { DocsButton } from '@/components/ui/DocsButton'
import { NoPermission } from '@/components/ui/NoPermission'
import { useSecretsDeleteMutation } from '@/data/secrets/secrets-delete-mutation'
import { useSecretsQuery } from '@/data/secrets/secrets-query'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
import { DOCS_URL } from '@/lib/constants'
export const EdgeFunctionSecrets = () => {
const { ref: projectRef } = useParams()
const workersEnabled = useFlag('workers')
const [searchString, setSearchString] = useState('')
const { can: canReadSecrets, isLoading: isLoadingSecretsPermissions } = useAsyncCheckPermissions(
PermissionAction.FUNCTIONS_SECRET_READ,
'*'
)
const { can: canUpdateSecrets } = useAsyncCheckPermissions(PermissionAction.SECRETS_WRITE, '*')
const {
data = [],
error,
isPending: isLoading,
isSuccess,
isError,
} = useSecretsQuery({ projectRef: projectRef }, { enabled: canReadSecrets })
const customSecrets = useMemo(
() => data.filter((secret) => !isInternalEdgeFunctionSecret(secret.name)),
[data]
)
const visibleDefaultSecrets = useMemo(
() => getVisibleDefaultEdgeFunctionSecrets(new Set(data.map((secret) => secret.name))),
[data]
)
const [selectedIdToEdit, setSelectedIdToEdit] = useQueryState(
'edit',
parseAsString.withOptions({ history: 'push', clearOnDefault: true })
)
const selectedSecretToEdit = useMemo(
() => customSecrets.find((secret) => secret.name === selectedIdToEdit),
[customSecrets, selectedIdToEdit]
)
const [selectedIdToDelete, setSelectedIdToDelete] = useQueryState(
'delete',
parseAsString.withOptions({ history: 'push', clearOnDefault: true })
)
const selectedSecretToDelete = useMemo(
() => customSecrets.find((secret) => secret.name === selectedIdToDelete),
[customSecrets, selectedIdToDelete]
)
const {
mutate: deleteSecret,
isPending: isDeleting,
isSuccess: isSuccessDelete,
} = useSecretsDeleteMutation({
onSuccess: (_, variables) => {
toast.success(`Successfully deleted secret “${variables.secrets[0]}`)
setSelectedIdToDelete(null)
},
})
const filteredCustomSecrets = useMemo(() => {
if (searchString.length === 0) return customSecrets
const search = searchString.toLowerCase()
return customSecrets.filter((secret) => secret.name.toLowerCase().includes(search))
}, [customSecrets, searchString])
const headers = [
<TableHead key="secret-name">Name</TableHead>,
<TableHead key="secret-value" className="flex items-center gap-x-2">
Digest <Badge variant="default">SHA256</Badge>
</TableHead>,
<TableHead key="secret-updated-at">Updated</TableHead>,
<TableHead key="actions" />,
]
const showLoadingState = isLoadingSecretsPermissions || (canReadSecrets && isLoading)
useEffect(() => {
if (!!selectedIdToEdit && isSuccess && !selectedSecretToEdit) {
toast(`Secret ${selectedIdToEdit} cannot be found`)
setSelectedIdToEdit(null)
}
}, [isSuccess, selectedIdToEdit, selectedSecretToEdit, setSelectedIdToEdit])
useEffect(() => {
if (!!selectedIdToDelete && isSuccess && !selectedSecretToDelete && !isSuccessDelete) {
toast(`Secret ${selectedIdToDelete} cannot be found`)
setSelectedIdToDelete(null)
}
}, [
isSuccess,
isSuccessDelete,
selectedIdToDelete,
selectedSecretToDelete,
setSelectedIdToDelete,
])
return (
<>
{showLoadingState ? (
<GenericSkeletonLoader />
) : !canReadSecrets ? (
<NoPermission resourceText="view this project's edge function secrets" />
) : (
<>
{isError && <AlertError error={error} subject="Failed to retrieve project secrets" />}
{isSuccess && (
<div className="space-y-10">
{canUpdateSecrets ? (
<AddNewSecretForm />
) : (
<NoPermission resourceText="manage this project's edge function secrets" />
)}
<section className="space-y-4">
<div className="flex flex-col md:flex-row md:items-center justify-between gap-2">
<div className="space-y-1">
<h3 className="text-foreground text-base">Custom secrets</h3>
<p className="text-sm text-foreground-light">
Secrets you have defined for this project
</p>
</div>
<Input
size="small"
className="w-full md:w-80"
placeholder="Search for a secret"
value={searchString}
onChange={(e) => setSearchString(e.target.value)}
icon={<Search />}
/>
</div>
<Card>
<Table>
<TableHeader>
<TableRow>{headers}</TableRow>
</TableHeader>
<TableBody>
{filteredCustomSecrets.length > 0 ? (
filteredCustomSecrets.map((secret) => (
<EdgeFunctionSecret
key={secret.name}
secret={secret}
onSelectEdit={() => setSelectedIdToEdit(secret.name)}
onSelectDelete={() => setSelectedIdToDelete(secret.name)}
/>
))
) : customSecrets.length === 0 ? (
<TableRow className="[&>td]:hover:bg-inherit">
<TableCell colSpan={headers.length}>
<p className="text-sm text-foreground">No custom secrets created</p>
<p className="text-sm text-foreground-lighter">
This project has no custom secrets yet.
</p>
</TableCell>
</TableRow>
) : (
<TableRow className="[&>td]:hover:bg-inherit">
<TableCell colSpan={headers.length}>
<p className="text-sm text-foreground">No results found</p>
<p className="text-sm text-foreground-light">
Your search for "{searchString}" did not return any results
</p>
</TableCell>
</TableRow>
)}
</TableBody>
</Table>
</Card>
</section>
<section className="space-y-4">
<div className="flex flex-col md:flex-row md:items-center justify-between gap-2">
<div className="space-y-1">
<h3 className="text-foreground text-base">Default secrets</h3>
<p className="text-sm text-foreground-light">
Reserved secrets available in every project
</p>
</div>
<DocsButton href={`${DOCS_URL}/guides/functions/secrets#default-secrets`} />
</div>
<DefaultEdgeFunctionSecrets secrets={visibleDefaultSecrets} />
</section>
</div>
)}
</>
)}
<EditSecretSheet
secret={selectedSecretToEdit}
visible={!!selectedSecretToEdit}
onClose={() => setSelectedIdToEdit(null)}
/>
<ConfirmationModal
variant="destructive"
loading={isDeleting}
visible={!!selectedSecretToDelete}
confirmLabel="Delete secret"
confirmLabelLoading="Deleting secret"
title={`Delete secret “${selectedSecretToDelete?.name}`}
onCancel={() => setSelectedIdToDelete(null)}
onConfirm={() => {
if (selectedSecretToDelete) {
deleteSecret({ projectRef, secrets: [selectedSecretToDelete.name] })
}
}}
>
{workersEnabled ? (
<p className="text-sm">
Ensure none of your <span className="font-medium">edge functions</span> or{' '}
<span className="font-medium">workers</span> are actively using this secret before
deleting it. This action cannot be undone.
</p>
) : (
<p className="text-sm">
Ensure none of your edge functions are actively using this secret before deleting it.
This action cannot be undone.
</p>
)}
</ConfirmationModal>
</>
)
}