mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Chore / dependency upgrade. ## What is the current behavior? Studio is on AI SDK 6 (`ai` ^6.0.174, `@ai-sdk/react` ^3). Tool approvals still use the v6 `needsApproval` flag on individual tools. ## What is the new behavior? Upgrades Studio to AI SDK 7 (`ai` 7.0.59) and the matching `@ai-sdk/*` packages. Aligns call sites with v7 names (`instructions`, `isStepCount`, `onEnd`, `ToolExecutionOptions`). This is the bottom of stack #49171. Later layers add a shared Confirm card and AssistantQueryCell. ## Additional context - Stack: #49167 → #49168 → #49169 → #49170 - `needsApproval` on tools is left as-is in this PR so the upgrade can land independently. A follow-up can move those gates to `streamText({ toolApproval })` and `experimental_toolApprovalSecret`. - Independent of the notebook preview stack ([#49112](https://github.com/supabase/supabase/pull/49112), [#49159](https://github.com/supabase/supabase/pull/49159)), which should merge first before we wrap notebook proposals in Confirm. ## Test plan - [ ] `pnpm --filter studio test` for `lib/ai/tools/*` and assistant generate path - [ ] Assistant chat still streams and tool-approval SQL / Edge Function still pause for confirm - [ ] Evals still run with mock tools (`needsApproval: false` overrides) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Updated AI-powered chat, onboarding, SQL, code completion, and recipe generation workflows for more reliable responses. * Streaming responses now better preserve reasoning and source information where available. * Improved tool privacy notices while preserving dynamically generated tool descriptions. * Refined AI response handling, including step limits and structured policy results. * **Bug Fixes** * Improved compatibility across AI-powered tool interactions and execution scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
219 lines
7.2 KiB
TypeScript
219 lines
7.2 KiB
TypeScript
import { components } from 'api-types'
|
|
import { HttpResponse } from 'msw'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
import { getReportTools } from './report-tools'
|
|
import { addAPIMock, type APIErrorBody } from '@/tests/lib/msw'
|
|
|
|
type GetUserContentByIdResponse = components['schemas']['GetUserContentByIdResponse']
|
|
|
|
describe('ai/tools/report-tools', () => {
|
|
describe('getReportTools', () => {
|
|
it('should return list_reports and get_report tools', () => {
|
|
const tools = getReportTools()
|
|
|
|
expect(Object.keys(tools)).toEqual(['list_reports', 'get_report'])
|
|
})
|
|
|
|
it('should not require approval to read reports', () => {
|
|
const tools = getReportTools()
|
|
|
|
expect(tools.list_reports.needsApproval).toBeUndefined()
|
|
expect(tools.get_report.needsApproval).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('list_reports', () => {
|
|
it('should list reports with summary fields, forwarding the authorization header', async () => {
|
|
let capturedRequest: Request | undefined
|
|
|
|
addAPIMock({
|
|
method: 'get',
|
|
path: '/platform/projects/:ref/content',
|
|
response: ({ request }) => {
|
|
capturedRequest = request
|
|
return HttpResponse.json({
|
|
data: [
|
|
{
|
|
id: 'report-1',
|
|
name: 'Home',
|
|
description: undefined,
|
|
visibility: 'project',
|
|
favorite: false,
|
|
folder_id: null,
|
|
inserted_at: '2026-01-01T00:00:00.000Z',
|
|
updated_at: '2026-01-01T00:00:00.000Z',
|
|
owner_id: 1,
|
|
owner: { id: 1, username: 'test' },
|
|
updated_by: { id: 1, username: 'test' },
|
|
project_id: 1,
|
|
type: 'report',
|
|
content: {
|
|
schema_version: 1,
|
|
period_start: { time_period: '7d' },
|
|
period_end: { time_period: 'today' },
|
|
interval: '1d',
|
|
layout: [{ id: 'a' }, { id: 'b' }],
|
|
},
|
|
},
|
|
],
|
|
})
|
|
},
|
|
})
|
|
|
|
const tools = getReportTools({ projectRef: 'test-project', authorization: 'Bearer token' })
|
|
if (!tools.list_reports.execute) throw new Error('execute is undefined')
|
|
|
|
const result = await tools.list_reports.execute(
|
|
{ limit: 20 },
|
|
{ toolCallId: 'test', messages: [], context: {} }
|
|
)
|
|
|
|
expect(capturedRequest?.headers.get('authorization')).toBe('Bearer token')
|
|
const url = new URL(capturedRequest!.url)
|
|
expect(url.pathname).toContain('/projects/test-project/content')
|
|
expect(url.searchParams.get('type')).toBe('report')
|
|
expect(url.searchParams.get('limit')).toBe('20')
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
id: 'report-1',
|
|
name: 'Home',
|
|
description: undefined,
|
|
visibility: 'project',
|
|
updated_at: '2026-01-01T00:00:00.000Z',
|
|
chart_count: 2,
|
|
},
|
|
])
|
|
})
|
|
})
|
|
|
|
describe('get_report', () => {
|
|
it('should resolve snippet_ chart blocks to their SQL', async () => {
|
|
addAPIMock({
|
|
method: 'get',
|
|
path: '/platform/projects/:ref/content/item/:id',
|
|
response: ({ params }) => {
|
|
if (params.id === 'report-1') {
|
|
return HttpResponse.json<GetUserContentByIdResponse>({
|
|
id: 'report-1',
|
|
name: 'My report',
|
|
description: undefined,
|
|
visibility: 'project',
|
|
favorite: false,
|
|
folder_id: null,
|
|
inserted_at: '2026-01-01T00:00:00.000Z',
|
|
updated_at: '2026-01-01T00:00:00.000Z',
|
|
owner_id: 1,
|
|
project_id: 1,
|
|
type: 'report',
|
|
content: {
|
|
schema_version: 1,
|
|
period_start: { time_period: '7d' },
|
|
period_end: { time_period: 'today' },
|
|
interval: '1d',
|
|
layout: [
|
|
{
|
|
id: 'snippet-1',
|
|
attribute: 'snippet_snippet-1',
|
|
x: 0,
|
|
y: 0,
|
|
w: 1,
|
|
h: 1,
|
|
label: 'My query',
|
|
provider: 'daily-stats',
|
|
chart_type: 'bar',
|
|
},
|
|
{
|
|
id: 'total_egress',
|
|
attribute: 'total_egress',
|
|
x: 1,
|
|
y: 0,
|
|
w: 1,
|
|
h: 1,
|
|
label: 'Egress',
|
|
provider: 'daily-stats',
|
|
chart_type: 'bar',
|
|
},
|
|
],
|
|
},
|
|
})
|
|
}
|
|
|
|
if (params.id === 'snippet-1') {
|
|
return HttpResponse.json<GetUserContentByIdResponse>({
|
|
id: 'snippet-1',
|
|
name: 'My query',
|
|
description: undefined,
|
|
visibility: 'user',
|
|
favorite: false,
|
|
folder_id: null,
|
|
inserted_at: '2026-01-01T00:00:00.000Z',
|
|
updated_at: '2026-01-01T00:00:00.000Z',
|
|
owner_id: 1,
|
|
project_id: 1,
|
|
type: 'sql',
|
|
content: { content_id: 'snippet-1', sql: 'select 1', schema_version: '1' },
|
|
})
|
|
}
|
|
|
|
return HttpResponse.json<APIErrorBody>(
|
|
{ message: `Unexpected id: ${params.id}` },
|
|
{ status: 404 }
|
|
)
|
|
},
|
|
})
|
|
|
|
const tools = getReportTools({ projectRef: 'test-project' })
|
|
if (!tools.get_report.execute) throw new Error('execute is undefined')
|
|
|
|
const result = (await tools.get_report.execute(
|
|
{ id: 'report-1' },
|
|
{ toolCallId: 'test', messages: [], context: {} }
|
|
)) as { layout: Array<{ id: string; attribute: string; sql?: string }> }
|
|
|
|
expect(result.layout).toEqual([
|
|
expect.objectContaining({
|
|
id: 'snippet-1',
|
|
attribute: 'snippet_snippet-1',
|
|
sql: 'select 1',
|
|
}),
|
|
expect.objectContaining({ id: 'total_egress', attribute: 'total_egress' }),
|
|
])
|
|
expect(result.layout[1].sql).toBeUndefined()
|
|
})
|
|
|
|
it('should throw when the content id is not a report', async () => {
|
|
addAPIMock({
|
|
method: 'get',
|
|
path: '/platform/projects/:ref/content/item/:id',
|
|
response: () =>
|
|
HttpResponse.json<GetUserContentByIdResponse>({
|
|
id: 'snippet-1',
|
|
name: 'My query',
|
|
description: undefined,
|
|
visibility: 'user',
|
|
favorite: false,
|
|
folder_id: null,
|
|
inserted_at: '2026-01-01T00:00:00.000Z',
|
|
updated_at: '2026-01-01T00:00:00.000Z',
|
|
owner_id: 1,
|
|
project_id: 1,
|
|
type: 'sql',
|
|
content: { content_id: 'snippet-1', sql: 'select 1', schema_version: '1' },
|
|
}),
|
|
})
|
|
|
|
const tools = getReportTools({ projectRef: 'test-project' })
|
|
if (!tools.get_report.execute) throw new Error('execute is undefined')
|
|
|
|
await expect(
|
|
tools.get_report.execute(
|
|
{ id: 'snippet-1' },
|
|
{ toolCallId: 'test', messages: [], context: {} }
|
|
)
|
|
).rejects.toThrow('is not a report')
|
|
})
|
|
})
|
|
})
|