mirror of
https://github.com/supabase/supabase.git
synced 2026-09-06 09:59:03 +08:00
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Small Assistant terminal-state fixes. ## Stack context This stack is based on #49352 (`chore/assistant-tool-outcomes`) and assumes #49350–#49352 merge first. Review bottom to top: 1. #49361 — assistant notebook run tool 2. #49362 — assistant notebook run UI 3. #49364 — terminal-state polish ## What is the current behavior? Completed notebook updates can be re-diffed against newer live content, and log-query failures can use SQL-specific or empty fallback UI. ## What is the new behavior? - Replaces completed notebook update previews with a stable success/error/skipped summary. - Keeps the Open notebook action on successful updates. - Uses logs-specific failure copy for Assistant log queries. - Shows an explicit fallback when a failed log tool input or output cannot be parsed. ## How to test manually ### Notebook update terminal states 1. Ask the AI Assistant to update an existing notebook, then approve the proposal. 2. Confirm the proposal becomes a compact **Notebook updated: [name]** summary instead of re-diffing against the newly saved notebook. 3. Click **Open notebook** and confirm it opens the updated notebook. 4. Request another notebook update and click **Skip**. Confirm the terminal summary says **Skipped notebook update**. 5. Refresh or reopen the conversation and confirm both summaries remain stable. ### Logs failure copy 1. Ask the Assistant to query Logs with an intentionally invalid table or column and approve the query. 2. Confirm the failed result says **Failed to query logs**, not **Failed to execute SQL**. 3. Confirm the failed tool remains visible rather than disappearing when its result cannot be rendered. ## Automated test The focused top-of-stack suite passes 9 test files and 85 tests. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added clearer failure messaging when query logs contain invalid input, missing results, or errors. - Added compact summaries for completed, failed, and skipped notebook updates. - Notebook update summaries include an “Open notebook” link when applicable. - **Bug Fixes** - Improved handling and display of query-log failures instead of showing blank content. - Preserved detailed previews for notebook updates that are still in progress. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
65 lines
2.0 KiB
TypeScript
65 lines
2.0 KiB
TypeScript
import { type ToolUIPart } from 'ai'
|
|
import { Loader2 } from 'lucide-react'
|
|
|
|
import { AssistantQueryCell } from './AssistantQueryCell'
|
|
import { useMessageInfoContext } from './Message.Context'
|
|
import {
|
|
getAssistantLogsQueryTitle,
|
|
getAssistantLogsTimeRange,
|
|
parseQueryLogsInput,
|
|
toQueryLogsResult,
|
|
} from './MessagePartQueryLogs.utils'
|
|
|
|
type QueryLogsToolPart = Pick<
|
|
ToolUIPart,
|
|
'toolCallId' | 'state' | 'input' | 'output' | 'errorText'
|
|
> & { rawInput?: unknown }
|
|
|
|
function QueryLogsFailure() {
|
|
return <div className="text-xs text-danger">Failed to query logs.</div>
|
|
}
|
|
|
|
export function MessagePartQueryLogs({ toolPart }: { toolPart: QueryLogsToolPart }) {
|
|
const { id } = useMessageInfoContext()
|
|
const { toolCallId, state, input: submittedInput, rawInput, output } = toolPart
|
|
|
|
if (state === 'input-streaming' || state === 'input-available') {
|
|
return (
|
|
<div className="my-4 rounded-lg border bg-surface-75 heading-meta h-9 px-3 text-foreground-light flex items-center gap-2">
|
|
<Loader2 className="w-4 h-4 animate-spin" />
|
|
Querying logs...
|
|
</div>
|
|
)
|
|
}
|
|
|
|
if (state !== 'output-available' && state !== 'output-error') return null
|
|
|
|
const parsedInput = parseQueryLogsInput(submittedInput ?? rawInput)
|
|
if (!parsedInput.success) return <QueryLogsFailure />
|
|
|
|
const result =
|
|
state === 'output-error'
|
|
? { rows: [], error: { message: toolPart.errorText ?? 'Failed to query logs' } }
|
|
: toQueryLogsResult(output)
|
|
if (!result) return <QueryLogsFailure />
|
|
|
|
return (
|
|
<div className="w-auto overflow-x-hidden my-4 space-y-2">
|
|
<AssistantQueryCell
|
|
id={`${id}-${toolCallId}`}
|
|
sql={parsedInput.data.sql}
|
|
title={getAssistantLogsQueryTitle(parsedInput.data.sql)}
|
|
source={{
|
|
_tag: 'logs',
|
|
time_range: getAssistantLogsTimeRange(
|
|
parsedInput.data.iso_timestamp_start,
|
|
parsedInput.data.iso_timestamp_end
|
|
),
|
|
}}
|
|
initialResult={result}
|
|
confirmState={state === 'output-error' ? 'error' : undefined}
|
|
/>
|
|
</div>
|
|
)
|
|
}
|