mirror of
https://github.com/supabase/supabase.git
synced 2026-09-06 09:59:03 +08:00
0791b04eb8
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Feature — progresses the SQL Editor manual saving rollout, and removes a fully rolled out feature flag. ## What is the current behavior? Manual saving (snippets save only on an explicit Save / Cmd+S rather than autosaving every edit) is opt-in. It requires both the `sqlEditorManualSave` ConfigCat flag and the user turning on the "Disable snippet auto-saving" feature preview themselves. That flag is now fully rolled out. ## What is the new behavior? - `sqlEditorManualSave` is removed, so the feature preview is listed for everyone. (Delete the flag in ConfigCat after a few months.) - New `sqlEditorManualSaveForced` flag progresses the rollout. It forces manual saving on regardless of what the user stored previously, including an explicit opt-out, via a new `isForced` field on `FeaturePreview` that `initializeFlags` resolves ahead of the localStorage lookup — so the feature preview modal reflects the forced state too, not just the save behavior. Turning the flag off reverts everyone who never opted in, so it remains a working kill switch. - Users the rollout switches over get a one-time dialog on their first SQL Editor route, explaining that snippets no longer autosave. Dismissal persists in `sql-editor-manual-save-notice-dismissed` (allowlisted, so it survives sign-out). - Users who opted into the preview themselves never see the dialog — it records their dismissal up front instead, since the notice needs to outlive the feature preview and once the preview is retired there's no stored opt-in left to recognize them by. - The preview keeps its switch so users who lose their local storage can opt in early, but once the rollout reaches them the "Disable feature" button is disabled with a tooltip explaining why. ### To test Turn on `sqlEditorManualSaveForced` on via the dev toolbar. - No `supabase-ui-sql-editor-manual-save` and no dismissal key → dialog appears on `/project/<ref>/sql`, toolbar shows the Save button. Dismiss, reload → no dialog. - `supabase-ui-sql-editor-manual-save` set to `false` (previously opted out) → still forced onto manual saving, and still gets the dialog. - `supabase-ui-sql-editor-manual-save` set to `true` → no dialog, and the dismissal key is written automatically. - Flag off, no opt-in → autosave, no dialog, and the "Disable autosave" power-off button still opens the preview modal. - Preview modal while forced → "Disable feature" is disabled with a tooltip; another preview (e.g. Column-level privileges) still disables normally. ## Additional context
37 lines
1.2 KiB
TypeScript
37 lines
1.2 KiB
TypeScript
export interface ShouldShowManualSaveNoticeParams {
|
|
/** Manual saving is a platform-only feature preview */
|
|
isPlatform: boolean
|
|
/** Whether the feature preview flags reflect loaded values rather than pre-load defaults */
|
|
isFeaturePreviewInitialized: boolean
|
|
/** Whether the rollout flag forces manual saving on for this user */
|
|
isForced: boolean
|
|
/** Whether the user explicitly enabled the manual save preview themselves */
|
|
hasOptedIntoPreview: boolean
|
|
isNoticeDismissed: boolean
|
|
}
|
|
|
|
/**
|
|
* Whether to show the one-time notice explaining that snippets no longer
|
|
* autosave.
|
|
*
|
|
* Everyone the rollout switches over needs telling — including users who
|
|
* explicitly opted *out* of the preview, since the rollout overrides that
|
|
* choice. Only users who turned manual saving on themselves already know what
|
|
* the behavior is.
|
|
*/
|
|
export function shouldShowManualSaveNotice({
|
|
isPlatform,
|
|
isFeaturePreviewInitialized,
|
|
isForced,
|
|
hasOptedIntoPreview,
|
|
isNoticeDismissed,
|
|
}: ShouldShowManualSaveNoticeParams): boolean {
|
|
return (
|
|
isPlatform &&
|
|
isFeaturePreviewInitialized &&
|
|
isForced &&
|
|
!hasOptedIntoPreview &&
|
|
!isNoticeDismissed
|
|
)
|
|
}
|