Files
supabase/apps/studio/components/interfaces/SQLEditor/SQLEditor.utils.ts
Charis 0433eeb5f5 feat(studio): mark sql provenance for safety (#45336)
Mark provenance of SQL via the branded types SafeSqlFragment and
UntrustedSqlFragment. Only SafeSqlFragment should be executed;
UntrustedSqlFragments require some kind of implicit user approval (show
on screen + user has to click something) before they are promoted to
SafeSqlFragment.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Editor and RLS tester show loading states for inferred/generated SQL
and include a dedicated user SQL editor for safer edits.

* **Refactor**
* Platform-wide SQL handling tightened: snippets and AI-generated SQL
are treated as untrusted/display-only until promoted, improving safety
and consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-05-04 13:08:06 -04:00

264 lines
9.6 KiB
TypeScript

import { untrustedSql, type SafeSqlFragment } from '@supabase/pg-meta'
import { TABLE_EVENT_ACTIONS } from 'common/telemetry-constants'
import {
alterDatabasePreventConnectionStatements,
destructiveSqlRegex,
NEW_SQL_SNIPPET_SKELETON,
sqlAiDisclaimerComment,
updateWithoutWhereRegex,
} from './SQLEditor.constants'
import { ContentDiff } from './SQLEditor.types'
import type { DatabaseEventTrigger } from '@/data/database-event-triggers/database-event-triggers-query'
import { generateUuid } from '@/lib/api/snippets.browser'
import { removeCommentsFromSql } from '@/lib/helpers'
import { sqlEventParser } from '@/lib/sql-event-parser'
import type { SnippetWithContent } from '@/state/sql-editor-v2'
export type CreateTableWithoutRLS = {
schema?: string
tableName: string
}
// The ensure_rls event trigger only auto-enables RLS on tables in the public
// schema (see AUTO_ENABLE_RLS_EVENT_TRIGGER_SQL).
const ENSURE_RLS_TRIGGER_SCHEMAS = new Set(['public'])
export function hasActiveEnsureRLSTrigger(triggers: DatabaseEventTrigger[] | undefined) {
return (
triggers?.some(
(t) =>
(t.name === 'ensure_rls' || t.function_name === 'rls_auto_enable') &&
t.enabled_mode !== 'DISABLED'
) ?? false
)
}
/**
* Filters out CREATE TABLE entries that will be covered by the project's
* ensure_rls event trigger (which only handles tables in the public schema).
* Tables in any other schema are returned unchanged so the user is still warned.
*/
export function filterTablesCoveredByEnsureRLSTrigger(
tables: CreateTableWithoutRLS[],
hasTrigger: boolean
): CreateTableWithoutRLS[] {
if (!hasTrigger) return tables
return tables.filter((t) => !ENSURE_RLS_TRIGGER_SCHEMAS.has((t.schema ?? 'public').toLowerCase()))
}
export const createSqlSnippetSkeletonV2 = ({
name,
sql,
owner_id,
project_id,
folder_id,
idOverride,
}: {
name: string
sql: string
owner_id: number
project_id: number
folder_id?: string
/**
* Optionally, provide a specific snippetId to use for the snippet. This is used to ensure the snippet is created
* with a known id, such as to prevent flicker in the SQL editor when adding new unsaved snippets.
*/
idOverride?: string
}): SnippetWithContent => {
const id = idOverride ?? generateUuid([folder_id, `${name}.sql`])
return {
...NEW_SQL_SNIPPET_SKELETON,
id,
owner_id,
project_id,
name,
folder_id,
favorite: false,
inserted_at: new Date().toISOString(),
updated_at: new Date().toISOString(),
content: {
...NEW_SQL_SNIPPET_SKELETON.content,
content_id: id ?? '',
unchecked_sql: untrustedSql(sql ?? ''),
} as any,
isNotSavedInDatabaseYet: true,
}
}
export function checkDestructiveQuery(sql: string) {
const cleanedSql = removeCommentsFromSql(sql)
return destructiveSqlRegex.some((regex) => regex.test(cleanedSql))
}
// Replace the contents of single-quoted string literals and double-quoted
// identifiers with empty quotes, so a downstream `where` scan can't be fooled
// by tokens like `UPDATE "where table" SET ...` or `SET name = 'where x'`.
// Postgres uses doubled quotes to escape, so `''` and `""` are matched as
// part of the same span rather than terminating it.
const stripQuotedSpans = (sql: string) =>
sql.replace(/'(?:''|[^'])*'/g, "''").replace(/"(?:""|[^"])*"/g, '""')
// Function to check for UPDATE queries without WHERE clause
export function isUpdateWithoutWhere(sql: string): boolean {
const updateStatements = sql
.split(';')
.filter((statement) => statement.trim().toLowerCase().startsWith('update'))
return updateStatements.some(
(statement) =>
updateWithoutWhereRegex.test(statement) && !/where\s/i.test(stripQuotedSpans(statement))
)
}
/**
* Returns CREATE TABLE statements in `sql` that do not have a matching
* ALTER TABLE ... ENABLE ROW LEVEL SECURITY in the same SQL submission.
*
* Operates on the SQL passed in (which is the user's selection if any, or the
* full editor contents otherwise) so partial-execution selects work naturally.
*/
export function getCreateTablesMissingRLS(sql: string): CreateTableWithoutRLS[] {
const events = sqlEventParser.getTableEvents(sql)
// Match case-sensitively. Lowercasing would let quoted identifiers like
// "MyTable" and "mytable" — which are different tables in Postgres — collide
// and silently suppress the warning. The trade-off is rare false positives
// when users mix case for *unquoted* identifiers (Postgres would have folded
// them anyway), which is annoying but safe.
const key = (e: { schema?: string; tableName?: string }) => `${e.schema ?? ''}.${e.tableName}`
const rlsEnabled = new Set(
events.filter((e) => e.type === TABLE_EVENT_ACTIONS.TableRLSEnabled && e.tableName).map(key)
)
return events
.filter((e) => e.type === TABLE_EVENT_ACTIONS.TableCreated && e.tableName)
.filter((e) => !rlsEnabled.has(key(e)))
.map((e) => ({ schema: e.schema, tableName: e.tableName as string }))
}
/**
* Appends `ALTER TABLE ... ENABLE ROW LEVEL SECURITY` statements to `sql`
* for each provided table.
*/
export function appendEnableRLSStatements(sql: string, tables: CreateTableWithoutRLS[]) {
if (tables.length === 0) return sql
// Postgres folds unquoted identifiers to lowercase, so any identifier that
// isn't strictly lowercase-safe (e.g. "MyTable", "user table") must be quoted
// to refer back to the original table.
const quote = (identifier: string) =>
/^[a-z_][a-z0-9_]*$/.test(identifier) ? identifier : `"${identifier.replace(/"/g, '""')}"`
const additions = tables
.map(({ schema, tableName }) => {
const target = schema ? `${quote(schema)}.${quote(tableName)}` : quote(tableName)
return `ALTER TABLE ${target} ENABLE ROW LEVEL SECURITY;`
})
.join('\n')
const trimmed = sql.replace(/\s+$/, '')
// If the SQL ends with a line comment, the appended ';' would be swallowed,
// so put the terminator on its own line.
const endsWithLineComment = /--[^\r\n]*$/.test(trimmed)
const separator = trimmed.endsWith(';') ? '\n\n' : endsWithLineComment ? '\n;\n\n' : ';\n\n'
return `${trimmed}${separator}-- Added by Supabase: enable Row Level Security on newly created tables\n${additions}\n`
}
export function checkAlterDatabaseConnection(sql: string): boolean {
const cleanedSql = removeCommentsFromSql(sql)
const statements = cleanedSql
.split(';')
.filter((statement) => statement.trim().toLowerCase().startsWith('alter database'))
return statements.some((statement) =>
alterDatabasePreventConnectionStatements.some((x) => statement.toLowerCase().includes(x))
)
}
export const generateMigrationCliCommand = (id: string, name: string, isNpx = false) =>
`
${isNpx ? 'npx ' : ''}supabase snippets download ${id} |
${isNpx ? 'npx ' : ''}supabase migration new ${name}
`.trim()
export const generateSeedCliCommand = (id: string, isNpx = false) =>
`
${isNpx ? 'npx ' : ''}supabase snippets download ${id} >> \\
supabase/seed.sql
`.trim()
export const generateFileCliCommand = (id: string, name: string, isNpx = false) =>
`
${isNpx ? 'npx ' : ''}supabase snippets download ${id} > \\
${name}.sql
`.trim()
export const compareAsModification = (sqlDiff: ContentDiff) => {
const formattedModified = sqlDiff.modified.replace(sqlAiDisclaimerComment, '').trim()
return {
original: sqlDiff.original,
modified: `${formattedModified}`,
}
}
export const compareAsAddition = (sqlDiff: ContentDiff) => {
const formattedOriginal = sqlDiff.original.replace(sqlAiDisclaimerComment, '').trim()
const formattedModified = sqlDiff.modified.replace(sqlAiDisclaimerComment, '').trim()
const newModified = (formattedOriginal ? formattedOriginal + '\n\n' : '') + formattedModified
return {
original: sqlDiff.original,
modified: newModified,
}
}
export const compareAsNewSnippet = (sqlDiff: ContentDiff) => {
return {
original: '',
modified: sqlDiff.modified,
}
}
// [Joshen] Just FYI as well the checks here on whether to append limit is quite restricted
// This is to prevent dashboard from accidentally appending limit to the end of a query
// thats not supposed to have any, since there's too many cases to cover.
// We can however look into making this logic better in the future
// i.e It's harder to append the limit param, than just leaving the query as it is
// Otherwise we'd need a full on parser to do this properly
export const checkIfAppendLimitRequired = (sql: string, limit: number = 0) => {
// Remove lines and whitespaces to use for checking
const cleanedSql = sql.trim().replaceAll('\n', ' ').replaceAll(/\s+/g, ' ')
// Check how many queries
const regMatch = cleanedSql.matchAll(/[a-zA-Z]*[0-9]*[;]+/g)
const queries = new Array(...regMatch)
const indexSemiColon = cleanedSql.lastIndexOf(';')
const hasComments = cleanedSql.includes('--')
const hasMultipleQueries =
queries.length > 1 || (indexSemiColon > 0 && indexSemiColon !== cleanedSql.length - 1)
// Check if need to auto limit rows
const appendAutoLimit =
limit > 0 &&
!hasComments &&
!hasMultipleQueries &&
cleanedSql.toLowerCase().startsWith('select') &&
!cleanedSql.toLowerCase().match(/fetch\s+first/i) &&
!cleanedSql.match(/limit$/i) &&
!cleanedSql.match(/limit;$/i) &&
!cleanedSql.match(/limit [0-9]* offset [0-9]*[;]?$/i) &&
!cleanedSql.match(/limit [0-9]*[;]?$/i)
return { cleanedSql, appendAutoLimit }
}
export const suffixWithLimit = (sql: SafeSqlFragment, limit: number = 0): SafeSqlFragment => {
const { cleanedSql, appendAutoLimit } = checkIfAppendLimitRequired(sql, limit)
if (!appendAutoLimit) return sql
return (
cleanedSql.endsWith(';') ? sql.replace(/[;]+$/, ` limit ${limit};`) : `${sql} limit ${limit};`
) as SafeSqlFragment
}