Files
supabase/apps/studio/components/interfaces/LogDrains/LogDrainDestinationSheetForm.test.tsx
Jordi Enric 34163fc0ca fix(studio): duplicate Content-Type on webhook log drains (#46673)
## Problem

Webhook log drains (project and org/audit) deliver requests with a
malformed, duplicated `Content-Type: application/jsonapplication/json`
header. On at least some receivers this breaks body parsing, so the
delivered body appears empty even though it is present (confirmed with
gzip both on and off).

Root cause: the create form seeds a default `Content-Type:
application/json` header for webhook drains, and the logflare webhook
adaptor's `Tesla.Middleware.JSON` also sets `content-type:
application/json` when it encodes the body. Both are sent, and the
receiver concatenates the two same-named headers.

## Fix

Stop seeding `Content-Type` in the webhook default headers
(`getDefaultHeadersByType`). The delivery side already sets it, so a
single clean header is sent. OTLP keeps its `application/x-protobuf`
default because the OTLP delivery path uses `json: false` and does not
set a content type itself.

Updated the form tests that assumed the seeded header (the added-header
row is now index 0 instead of 1, and the duplicate-header test now adds
two explicit rows).

## How to test

- Create a webhook (Custom Endpoint) audit log drain pointing at a
request bin.
- Trigger an audit event and inspect the delivered request:
`Content-Type` should be a single `application/json`, and the JSON body
should be visible.

## Note

This fixes the common case (the seeded default). A user who manually
adds a `Content-Type` header to a webhook drain would still hit the
duplication; the robust cross-team fix would be for the logflare webhook
adaptor to drop an incoming `content-type` before its JSON middleware
sets one. Flagging for the logs team.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Log Drain header handling corrected: webhook drains no longer add a
default Content-Type; other drain types retain their appropriate
defaults. Empty header rows are no longer submitted.
* **Tests**
* Updated tests to match new header indexing, validation behavior, and
submission expectations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-05 17:55:23 +02:00

288 lines
9.1 KiB
TypeScript

import { fireEvent, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import type { ComponentProps } from 'react'
import { toast } from 'sonner'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { LogDrainDestinationSheetForm } from './LogDrainDestinationSheetForm'
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
import { render } from '@/tests/helpers'
const { mockShortcut, trackMock, useFlagMock, useLogDrainsQueryMock, useParamsMock, useTrackMock } =
vi.hoisted(() => ({
mockShortcut: vi.fn(({ children }: any) => <div data-testid="shortcut">{children}</div>),
trackMock: vi.fn(),
useFlagMock: vi.fn(),
useLogDrainsQueryMock: vi.fn(),
useParamsMock: vi.fn(),
useTrackMock: vi.fn(),
}))
vi.mock(import('common'), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
IS_PLATFORM: false,
useFlag: useFlagMock,
useParams: useParamsMock,
}
})
vi.mock(import('@/data/log-drains/log-drains-query'), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
useLogDrainsQuery: useLogDrainsQueryMock,
}
})
vi.mock('@/lib/telemetry/track', () => ({
useTrack: useTrackMock,
}))
vi.mock('@/components/ui/Shortcut', () => ({
Shortcut: mockShortcut,
}))
vi.mock('sonner', () => ({
toast: {
error: vi.fn(),
success: vi.fn(),
},
}))
const renderForm = (props?: Partial<ComponentProps<typeof LogDrainDestinationSheetForm>>) => {
const onOpenChange = vi.fn()
const onSubmit = vi.fn()
render(
<LogDrainDestinationSheetForm
open
mode="create"
isLoading={false}
onOpenChange={onOpenChange}
onSubmit={onSubmit}
defaultValues={{ type: 'webhook' }}
{...props}
/>
)
return { onOpenChange, onSubmit }
}
const submitForm = () =>
fireEvent.submit(document.getElementById('log-drain-destination-form') as HTMLFormElement)
describe('LogDrainDestinationSheetForm', () => {
beforeEach(() => {
vi.clearAllMocks()
useFlagMock.mockReturnValue(true)
useParamsMock.mockReturnValue({ ref: 'project-ref' })
useLogDrainsQueryMock.mockReturnValue({ data: [] })
useTrackMock.mockReturnValue(trackMock)
})
it('does not prefill a Content-Type header for webhook create mode', async () => {
renderForm()
await screen.findByRole('dialog')
expect(screen.queryByDisplayValue('Content-Type')).not.toBeInTheDocument()
expect(screen.queryByDisplayValue('application/json')).not.toBeInTheDocument()
})
it('wraps the save button with the save destination shortcut while open', async () => {
renderForm()
await screen.findByRole('dialog')
expect(mockShortcut).toHaveBeenCalledWith(
expect.objectContaining({
id: SHORTCUT_IDS.LOG_DRAINS_SAVE_DESTINATION,
onTrigger: expect.any(Function),
options: { enabled: true },
side: 'top',
}),
undefined
)
expect(screen.getByRole('button', { name: 'Save destination' })).toBeInTheDocument()
})
it('blocks submission when the destination name matches an existing drain', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm({ existingDrainNames: ['existing-drain'] })
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'existing-drain')
submitForm()
await waitFor(() => expect(toast.error).toHaveBeenCalledWith('Log drain name already exists'))
expect(onSubmit).not.toHaveBeenCalled()
})
it('invokes onSaveClick with the destination type when saving', async () => {
const user = userEvent.setup()
const onSaveClick = vi.fn()
const { onSubmit } = renderForm({ onSaveClick })
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
submitForm()
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
expect(onSaveClick).toHaveBeenCalledWith('webhook')
})
it('shows the protobuf content type header for OTLP create mode', async () => {
renderForm({
defaultValues: { type: 'otlp' },
})
await screen.findByRole('dialog')
expect(screen.getByDisplayValue('Content-Type')).toBeInTheDocument()
expect(screen.getByDisplayValue('application/x-protobuf')).toBeInTheDocument()
})
it('submits headers as a record without leaking the internal headerEntries field', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm()
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
const headerNameInputs = screen.getAllByPlaceholderText('Header name')
const headerValueInputs = screen.getAllByPlaceholderText('Header value')
await user.type(headerNameInputs[0], 'X-API-Key')
await user.type(headerValueInputs[0], 'secret-key')
submitForm()
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
expect(onSubmit).toHaveBeenCalledWith(
expect.objectContaining({
type: 'webhook',
headers: {
'X-API-Key': 'secret-key',
},
})
)
expect(onSubmit.mock.calls[0][0]).not.toHaveProperty('headerEntries')
})
it('rejects duplicate header names with an inline field error', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm()
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
const headerNameInputs = screen.getAllByPlaceholderText('Header name')
const headerValueInputs = screen.getAllByPlaceholderText('Header value')
await user.type(headerNameInputs[0], 'X-Custom')
await user.type(headerValueInputs[0], 'one')
await user.type(headerNameInputs[1], 'X-Custom')
await user.type(headerValueInputs[1], 'two')
submitForm()
expect((await screen.findAllByText('Header name already exists')).length).toBeGreaterThan(0)
expect(onSubmit).not.toHaveBeenCalled()
})
it('allows fully empty header rows without blocking submit', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm()
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
submitForm()
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
expect(onSubmit).toHaveBeenCalledWith(
expect.objectContaining({
type: 'webhook',
})
)
expect(onSubmit.mock.calls[0][0]).not.toHaveProperty('headers')
expect(screen.queryByText('undefined')).not.toBeInTheDocument()
})
it('shows an inline value error when a header key is entered without a value', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm()
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
const headerNameInputs = screen.getAllByPlaceholderText('Header name')
await user.type(headerNameInputs[0], 'X-Draft-Only')
submitForm()
expect(await screen.findByText('Header value is required')).toBeInTheDocument()
expect(onSubmit).not.toHaveBeenCalled()
expect(screen.queryByText('undefined')).not.toBeInTheDocument()
})
it('shows an inline key error when a header value is entered without a key', async () => {
const user = userEvent.setup()
const { onSubmit } = renderForm()
await screen.findByRole('dialog')
await user.type(screen.getByPlaceholderText('My Destination'), 'Webhook sink')
await user.type(
screen.getByPlaceholderText('https://example.com/log-drain'),
'https://logs.example.com/ingest'
)
await user.click(screen.getByRole('button', { name: 'Add a new header' }))
const headerValueInputs = screen.getAllByPlaceholderText('Header value')
await user.type(headerValueInputs[0], 'draft-value')
submitForm()
expect(await screen.findByText('Header name is required')).toBeInTheDocument()
expect(onSubmit).not.toHaveBeenCalled()
expect(screen.queryByText('undefined')).not.toBeInTheDocument()
})
})