Files
supabase/apps/studio/components/interfaces/Integrations/Vault/Secrets/AddNewSecretModal.tsx
Ali Waseem 47dbbddc91 chore: fix secrets editor for functions to be text area/ support newlines (#46754)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Update to support text area for functions

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Secret inputs now accept and preserve multi-line values and
auto-resize to fit content.
* Secret values can be masked/unmasked via a show/hide toggle with
tooltip; masking uses styled concealment.
* Per-secret controls refined: clearer row layout, dedicated remove
icon, and add/save controls moved to the card footer.

* **Tests**
* Added tests validating multi-line secret entry and that submitted
payloads include embedded newlines.
* Updated tests to assert masking/unmasking behavior via visual security
styling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: kemal <hello@kemal.earth>
2026-06-12 08:11:36 -06:00

192 lines
6.4 KiB
TypeScript

import { zodResolver } from '@hookform/resolvers/zod'
import { Eye, EyeOff } from 'lucide-react'
import { parseAsBoolean, useQueryState } from 'nuqs'
import { useState } from 'react'
import { SubmitHandler, useForm } from 'react-hook-form'
import { toast } from 'sonner'
import {
Button,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
Form,
FormControl,
FormField,
Input,
Textarea,
Tooltip,
TooltipContent,
TooltipTrigger,
} from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import * as z from 'zod'
import { useVaultSecretCreateMutation } from '@/data/vault/vault-secret-create-mutation'
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
const formSchema = z.object({
name: z.string().min(1, 'Please provide a name for your secret'),
description: z.string().optional(),
secret: z.string().min(1, 'Please enter your secret value'),
})
type FormSchema = z.infer<typeof formSchema>
const formId = 'add-new-secret-form'
export const AddNewSecretModal = () => {
const { data: project } = useSelectedProjectQuery()
const { mutateAsync: addSecret } = useVaultSecretCreateMutation()
const [isSecretVisible, setIsSecretVisible] = useState(false)
const [showAddSecretModal, setShowAddSecretModal] = useQueryState(
'new',
parseAsBoolean.withDefault(false)
)
const handleClose = () => {
setShowAddSecretModal(null)
setIsSecretVisible(false)
form.reset()
}
const onAddNewSecret: SubmitHandler<FormSchema> = async (values) => {
if (!project) return console.error('Project is required')
try {
await addSecret({
projectRef: project.ref,
connectionString: project?.connectionString,
name: values.name,
description: values.description,
secret: values.secret,
})
toast.success(`Successfully added new secret ${values.name}`)
handleClose()
} catch (error: any) {
// [Joshen] No error handler required as they are all handled within the mutations already
} finally {
}
}
const form = useForm<FormSchema>({
resolver: zodResolver(formSchema),
defaultValues: { name: '', description: '', secret: '' },
})
const { isDirty, isSubmitting } = form.formState
return (
<Dialog open={showAddSecretModal} onOpenChange={handleClose}>
<DialogContent className="sm:max-w-[425px]">
<DialogHeader>
<DialogTitle>Add new secret</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<DialogSection className="space-y-4">
<Form {...form}>
<form
id={formId}
noValidate
onSubmit={form.handleSubmit(onAddNewSecret)}
className="space-y-4"
>
<FormField
control={form.control}
name="name"
render={({ field }) => (
<FormItemLayout layout="vertical" label="Name">
<FormControl className="col-span-6">
<Input {...field} />
</FormControl>
</FormItemLayout>
)}
/>
<FormField
control={form.control}
name="description"
render={({ field }) => (
<FormItemLayout layout="vertical" label="Description" labelOptional="Optional">
<FormControl className="col-span-6">
<Input {...field} />
</FormControl>
</FormItemLayout>
)}
/>
<FormField
control={form.control}
name="secret"
render={({ field }) => (
<FormItemLayout layout="vertical" label="Secret value">
<FormControl className="col-span-6">
<div className="relative">
<Textarea
{...field}
rows={1}
ref={(el) => {
field.ref(el)
if (el) {
el.style.height = 'auto'
el.style.height = Math.max(40, el.scrollHeight) + 'px'
}
}}
className="min-h-0 resize-none"
style={
{
WebkitTextSecurity: isSecretVisible ? undefined : 'disc',
} as React.CSSProperties
}
onChange={(e) => {
field.onChange(e)
e.currentTarget.style.height = 'auto'
e.currentTarget.style.height =
Math.max(40, e.currentTarget.scrollHeight) + 'px'
}}
/>
<Tooltip>
<TooltipTrigger asChild>
<Button
type="text"
className="absolute right-1 top-1 px-1"
aria-label={
isSecretVisible ? 'Hide secret value' : 'Show secret value'
}
icon={isSecretVisible ? <EyeOff /> : <Eye />}
onClick={() => setIsSecretVisible((prev) => !prev)}
/>
</TooltipTrigger>
<TooltipContent side="bottom">
{isSecretVisible ? 'Hide value' : 'Show value'}
</TooltipContent>
</Tooltip>
</div>
</FormControl>
</FormItemLayout>
)}
/>
</form>
</Form>
</DialogSection>
<DialogFooter>
<Button type="default" disabled={isSubmitting} onClick={handleClose}>
Cancel
</Button>
<Button
form={formId}
htmlType="submit"
disabled={!isDirty || isSubmitting}
loading={isSubmitting}
>
Add secret
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
)
}