mirror of
https://github.com/supabase/supabase.git
synced 2026-09-08 19:08:44 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
25 lines
580 B
TypeScript
25 lines
580 B
TypeScript
import { Mail } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
export default function ButtonDemo() {
|
|
return (
|
|
<div className="flex gap-3">
|
|
<Button variant="default" size="tiny">
|
|
Tiny Button
|
|
</Button>
|
|
<Button variant="default" size="small">
|
|
Small button
|
|
</Button>
|
|
<Button variant="default" size="medium">
|
|
Medium button
|
|
</Button>
|
|
<Button variant="default" size="large">
|
|
Large button
|
|
</Button>
|
|
<Button variant="default" size="xlarge">
|
|
Huge button
|
|
</Button>
|
|
</div>
|
|
)
|
|
}
|