mirror of
https://github.com/supabase/supabase.git
synced 2026-09-07 02:20:52 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
20 lines
467 B
TypeScript
20 lines
467 B
TypeScript
import { Mail } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
export default function ButtonGhost() {
|
|
return (
|
|
<div className="flex gap-3">
|
|
<Button variant="text">Button rest</Button>
|
|
<Button variant="text" loading>
|
|
Button loading
|
|
</Button>
|
|
<Button variant="text" icon={<Mail />}>
|
|
Button icon
|
|
</Button>
|
|
<Button variant="text" iconRight={<Mail />}>
|
|
Button iconRight
|
|
</Button>
|
|
</div>
|
|
)
|
|
}
|