mirror of
https://github.com/supabase/supabase.git
synced 2026-09-09 03:19:36 +08:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
85 lines
2.3 KiB
TypeScript
85 lines
2.3 KiB
TypeScript
'use client'
|
|
|
|
import { PauseCircle, PlayCircle } from 'lucide-react'
|
|
import Image from 'next/image'
|
|
import { useEffect, useState } from 'react'
|
|
import { cn } from 'ui'
|
|
|
|
interface ImageFadeStackProps {
|
|
autoplay?: boolean
|
|
images: string[]
|
|
height?: 'default'
|
|
delay?: number
|
|
altText?: string
|
|
showNavigation?: boolean
|
|
}
|
|
|
|
const ImageFadeStack = ({
|
|
images,
|
|
height = 'default',
|
|
delay = 3000,
|
|
autoplay = false,
|
|
altText = 'Image',
|
|
showNavigation = false,
|
|
}: ImageFadeStackProps) => {
|
|
const [currentImageIndex, setCurrentImageIndex] = useState(0)
|
|
const [isPlaying, setIsPlaying] = useState(autoplay)
|
|
|
|
useEffect(() => {
|
|
if (isPlaying) {
|
|
const intervalId = setInterval(() => {
|
|
setCurrentImageIndex((prevIndex) => (prevIndex + 1) % images.length)
|
|
}, delay)
|
|
|
|
return () => clearInterval(intervalId)
|
|
}
|
|
}, [images, isPlaying])
|
|
|
|
function handleNavClick(index: number) {
|
|
setIsPlaying(false)
|
|
setCurrentImageIndex(index)
|
|
}
|
|
|
|
return (
|
|
<div className={`relative ${height === 'default' ? 'h-[300px]' : 'h-[400px]'} my-6`}>
|
|
{images.map((image, index) => (
|
|
<>
|
|
<Image
|
|
className="absolute top-0 left-0"
|
|
key={index}
|
|
src={image}
|
|
layout="fill"
|
|
alt={altText}
|
|
style={{
|
|
opacity: currentImageIndex === index ? 1 : 0,
|
|
transition: 'opacity 1s ease-in-out',
|
|
}}
|
|
/>
|
|
</>
|
|
))}
|
|
<div className="absolute bottom-4 right-4 flex gap-3">
|
|
{showNavigation &&
|
|
images.map((_, index) => (
|
|
<button tabIndex={0} className="text-white" onClick={() => handleNavClick(index)}>
|
|
<div
|
|
className={cn(
|
|
'w-2 h-2 rounded-full bg-foreground-muted hover:bg-surface-100 transition-colors',
|
|
currentImageIndex === index && 'bg-border-strong'
|
|
)}
|
|
/>
|
|
</button>
|
|
))}
|
|
<button
|
|
tabIndex={0}
|
|
onClick={() => setIsPlaying(!isPlaying)}
|
|
className="text-white bg-foreground-light hover:bg-overlay rounded-full p-0.5 transition-colors"
|
|
>
|
|
{isPlaying ? <PauseCircle size={12} /> : <PlayCircle size={12} />}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|
|
|
|
export default ImageFadeStack
|