mirror of
https://github.com/supabase/supabase.git
synced 2026-09-08 19:08:44 +08:00
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
35 lines
930 B
TypeScript
35 lines
930 B
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { Plus } from 'lucide-react'
|
|
import { MouseEventHandler } from 'react'
|
|
|
|
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
|
|
export const CreateBucketButton = ({
|
|
onClick,
|
|
}: {
|
|
onClick: MouseEventHandler<HTMLButtonElement>
|
|
}) => {
|
|
const { can: canCreateBuckets } = useAsyncCheckPermissions(PermissionAction.STORAGE_WRITE, '*')
|
|
|
|
return (
|
|
<ButtonTooltip
|
|
block
|
|
size="tiny"
|
|
variant="primary"
|
|
className="w-fit"
|
|
icon={<Plus size={14} />}
|
|
disabled={!canCreateBuckets}
|
|
onClick={onClick}
|
|
tooltip={{
|
|
content: {
|
|
side: 'bottom',
|
|
text: !canCreateBuckets ? 'You need additional permissions to create buckets' : undefined,
|
|
},
|
|
}}
|
|
>
|
|
New bucket
|
|
</ButtonTooltip>
|
|
)
|
|
}
|