mirror of
https://github.com/supabase/supabase.git
synced 2026-09-12 12:59:54 +08:00
Follow-up to #48344: collapses the two resolution paths for the Admonition module into one. `src/admonition.tsx` was a back-compat shim re-exporting `src/Admonition/`. Two ways to resolve one module is exactly what produced the macOS self-import bug fixed in #48344, and the local typecheck errors that #48374 worked around. This removes the shim and standardizes on the PascalCase subpath, matching every other export in the package. **Changed:** - Codemodded all 246 `ui-patterns/admonition` imports to `ui-patterns/Admonition` (240 `.tsx`, 5 `.mdx`, 1 `.ts` across studio, docs, www, design-system, and lite-studio) - Pointed the 5 internal `'../admonition'` imports back at the `'../Admonition'` directory **Removed:** - `packages/ui-patterns/src/admonition.tsx`, and its `./admonition` entry in the exports map (regenerated with `pnpm gen:exports`) ## To test - `grep -r "ui-patterns/admonition" --include='*.ts*'` → no hits - `pnpm test:case-hazards` → passes - `pnpm typecheck` → all 15 tasks green - `pnpm --filter studio run lint:ratchet` → passes - `pnpm --filter ui-patterns vitest run src/Admonition` → 11 tests pass <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Standardized Admonition component imports across the application and documentation. * Improved compatibility with case-sensitive environments by using the canonical component path. * Removed the legacy Admonition import entry point. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
70 lines
2.0 KiB
TypeScript
70 lines
2.0 KiB
TypeScript
import {
|
|
AlertDialog,
|
|
AlertDialogAction,
|
|
AlertDialogBody,
|
|
AlertDialogCancel,
|
|
AlertDialogContent,
|
|
AlertDialogDescription,
|
|
AlertDialogFooter,
|
|
AlertDialogHeader,
|
|
AlertDialogTitle,
|
|
} from 'ui'
|
|
import { Admonition } from 'ui-patterns/Admonition'
|
|
|
|
import type { JitUserRule } from './JitDbAccess.types'
|
|
|
|
interface JitDbAccessDeleteDialogProps {
|
|
user: JitUserRule | null
|
|
isDeleting: boolean
|
|
error?: string | null
|
|
onClose: () => void
|
|
onConfirm: () => unknown
|
|
}
|
|
|
|
export function JitDbAccessDeleteDialog({
|
|
user,
|
|
isDeleting = false,
|
|
error,
|
|
onClose,
|
|
onConfirm,
|
|
}: JitDbAccessDeleteDialogProps) {
|
|
const userDisplayName = user?.name?.trim() || user?.email || 'this user'
|
|
|
|
return (
|
|
<AlertDialog open={!!user} onOpenChange={(open) => !open && !isDeleting && onClose()}>
|
|
<AlertDialogContent size="small">
|
|
<AlertDialogHeader>
|
|
<AlertDialogTitle>Delete temporary access rule</AlertDialogTitle>
|
|
<AlertDialogDescription asChild>
|
|
<div className="space-y-2 text-sm">
|
|
<p>
|
|
Remove the temporary access rule for{' '}
|
|
<strong className="text-foreground">{userDisplayName}</strong>?
|
|
</p>
|
|
<p>
|
|
This revokes any assigned database roles for this member and removes their temporary
|
|
access configuration.
|
|
</p>
|
|
</div>
|
|
</AlertDialogDescription>
|
|
</AlertDialogHeader>
|
|
{error && (
|
|
<AlertDialogBody>
|
|
<Admonition
|
|
type="destructive"
|
|
title="Unable to delete temporary access rule"
|
|
description={error}
|
|
/>
|
|
</AlertDialogBody>
|
|
)}
|
|
<AlertDialogFooter>
|
|
<AlertDialogCancel disabled={isDeleting}>Cancel</AlertDialogCancel>
|
|
<AlertDialogAction variant="danger" loading={isDeleting} onClick={onConfirm}>
|
|
Delete rule
|
|
</AlertDialogAction>
|
|
</AlertDialogFooter>
|
|
</AlertDialogContent>
|
|
</AlertDialog>
|
|
)
|
|
}
|