Files
supabase/apps/studio/components/interfaces/Settings/API/DataApiEnableSwitch.tsx
Charis 50e1eb7436 chore(eslint): bump eslint-config-next to v16 for useEffectEvent (#48458)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Chore / build (ESLint config upgrade + lint cleanup).

## What is the current behavior?

`eslint-plugin-react-hooks` v5 (pulled in transitively by
`eslint-config-next` v15) doesn't recognize stable `useEffectEvent`, so
every effect that calls an effect-event handler needs an `eslint-disable
react-hooks/exhaustive-deps` to silence a false positive. There are 30
such dead disables across Studio.

## What is the new behavior?

Bumps `eslint-config-next` to v16, which pulls in
`eslint-plugin-react-hooks` v7 whose `exhaustive-deps` understands
`useEffectEvent`, and removes the 30 now-dead disable directives (and
their orphaned explanatory comments).

Supporting changes:

- **Flat-config migration**: v16 is a native flat-config array (v15 was
eslintrc), so `eslint-config-supabase` now spreads it directly instead
of bridging through `FlatCompat`.
- **React Compiler rules off**: v16 enables react-hooks v7's
`recommended`, which layers the React Compiler lint rules on top of the
two classic rules. These are switched off (derived dynamically from what
next enables) to keep this change scoped to the `exhaustive-deps`
improvement.
- **Plugin-registration fallout** (v16 scopes plugin registration to a
file glob rather than registering globally like FlatCompat did): stop
re-registering `@typescript-eslint` (shared) and `jsx-a11y` (studio);
scope our react / react-hooks / jsx-a11y rule overrides (studio, www) to
v16's plugin glob so they don't error on files outside it (e.g. `.cjs`).
- **Lint surface preserved**: v16's glob newly includes `.mts`/`.cts`
(v15 didn't lint them), which surfaced pre-existing errors in tooling
scripts. The shared config keeps the prior surface by leaving
`.mts`/`.cts` unlinted; linting them is left as a separate change.
- **Ratchet**: rebaselines `@tanstack/query/exhaustive-deps` 9 → 89. v15
forced next's `@babel/eslint-parser` onto `.ts` files, hiding these
deps; v16 parses `.ts` with `@typescript-eslint/parser` and correctly
surfaces the intentional `connectionString`-excluded-from-`queryKey`
pattern. Worth a follow-up to review whether any are real
cache-correctness bugs.
- Drops three now-dead devDeps from `eslint-config-supabase`:
`@eslint/eslintrc`, `@eslint/js`, `@typescript-eslint/eslint-plugin`.

Verified locally: `turbo run lint` → 7/7 packages pass with 0 errors;
Studio `lint:ratchet` passes; Prettier clean on changed files; typecheck
unaffected.

## Additional context

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Refined linting configuration and removed outdated lint suppressions
across Studio.
* Updated Next.js linting support and refreshed related development
configuration.
  * Expanded lint baseline coverage for query-related code.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-07-31 09:01:05 -04:00

163 lines
5.3 KiB
TypeScript

import { zodResolver } from '@hookform/resolvers/zod'
import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useParams } from 'common'
import { useCallback, useEffect, useEffectEvent, useReducer } from 'react'
import { useForm } from 'react-hook-form'
import { toast } from 'sonner'
import { Card } from 'ui'
import { dataApiFormSchema, type DataApiFormValues } from './DataApiEnableSwitch.types'
import {
enableCheckReducer,
getDefaultSchemas,
queryUnsafeEntitiesInApi,
} from './DataApiEnableSwitch.utils'
import { DataApiEnableSwitchForm } from './DataApiEnableSwitchForm'
import { DataApiEnableSwitchError, DataApiEnableSwitchLoading } from './DataApiEnableSwitchStates'
import { UnsafeEntitiesConfirmModal } from './UnsafeEntitiesConfirmModal'
import { useProjectPostgrestConfigQuery } from '@/data/config/project-postgrest-config-query'
import { useProjectPostgrestConfigUpdateMutation } from '@/data/config/project-postgrest-config-update-mutation'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
import { useIsDataApiEnabled } from '@/hooks/misc/useIsDataApiEnabled'
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
export const DataApiEnableSwitch = () => {
const { ref: projectRef } = useParams()
const { data: project } = useSelectedProjectQuery()
const { can: canUpdatePostgrestConfig, isSuccess: isPermissionsLoaded } =
useAsyncCheckPermissions(PermissionAction.UPDATE, 'custom_config_postgrest')
const {
data: config,
isError,
isPending: isLoadingConfig,
} = useProjectPostgrestConfigQuery({ projectRef })
const { isEnabled, isPending: isEnabledCheckPending } = useIsDataApiEnabled({ projectRef })
const { mutate: updatePostgrestConfig, isPending: isUpdating } =
useProjectPostgrestConfigUpdateMutation({
onSuccess: (_data, variables) => {
toast.success(variables.dbSchema ? 'Data API enabled' : 'Data API disabled')
},
})
const [enableCheck, dispatchEnableCheck] = useReducer(enableCheckReducer, { status: 'idle' })
const formId = 'data-api-enable-form'
const isLoading = isLoadingConfig || !projectRef
const form = useForm<DataApiFormValues>({
resolver: zodResolver(dataApiFormSchema),
mode: 'onChange',
defaultValues: {
enableDataApi: false,
},
})
const syncForm = useEffectEvent(() => {
if (!isEnabledCheckPending) {
form.reset({ enableDataApi: isEnabled })
}
})
useEffect(() => {
syncForm()
}, [isEnabled])
const doUpdate = useCallback(
(enableDataApi: boolean) => {
if (!projectRef || !config) return
const dbSchema = enableDataApi ? getDefaultSchemas(config.db_schema).join(', ') : ''
updatePostgrestConfig({
projectRef,
dbSchema,
maxRows: config.max_rows,
dbExtraSearchPath: config.db_extra_search_path ?? '',
dbPool: config.db_pool ?? null,
})
},
[projectRef, config, updatePostgrestConfig]
)
const onSubmit = useCallback(
async ({ enableDataApi }: DataApiFormValues) => {
if (!projectRef) return
if (!enableDataApi || isEnabled) {
doUpdate(enableDataApi)
return
}
// Enabling — check for entities with security issues in the target schemas
const targetSchemas = getDefaultSchemas(config?.db_schema)
dispatchEnableCheck({ type: 'START_CHECK' })
try {
const entities = await queryUnsafeEntitiesInApi({
projectRef,
connectionString: project?.connectionString,
schemas: targetSchemas,
})
if (entities.length > 0) {
dispatchEnableCheck({ type: 'ENTITIES_FOUND', unsafeEntities: entities })
} else {
dispatchEnableCheck({ type: 'DISMISS' })
doUpdate(true)
}
} catch (error) {
console.error('Failed to check for exposed entities', error)
dispatchEnableCheck({ type: 'DISMISS' })
toast.error('Failed to check for exposed entities')
}
},
[projectRef, isEnabled, config?.db_schema, project?.connectionString, doUpdate]
)
const handleReset = useCallback(() => {
if (isEnabledCheckPending) return
form.reset({ enableDataApi: isEnabled })
}, [isEnabledCheckPending, isEnabled, form])
const isBusy = isUpdating || enableCheck.status === 'checking'
const disabled = !canUpdatePostgrestConfig || isBusy
const permissionsHelper =
isPermissionsLoaded && !canUpdatePostgrestConfig
? "You need additional permissions to update your project's API settings"
: undefined
const cardContent = isLoading ? (
<DataApiEnableSwitchLoading />
) : isError || !config ? (
<DataApiEnableSwitchError />
) : (
<DataApiEnableSwitchForm
form={form}
formId={formId}
disabled={disabled}
isBusy={isBusy}
permissionsHelper={permissionsHelper}
onSubmit={onSubmit}
handleReset={handleReset}
/>
)
return (
<>
<Card>{cardContent}</Card>
<UnsafeEntitiesConfirmModal
visible={enableCheck.status === 'confirming'}
loading={isUpdating}
unsafeEntities={enableCheck.status === 'confirming' ? enableCheck.unsafeEntities : []}
onCancel={() => dispatchEnableCheck({ type: 'DISMISS' })}
onConfirm={() => {
dispatchEnableCheck({ type: 'DISMISS' })
doUpdate(true)
}}
/>
</>
)
}