mirror of
https://github.com/supabase/supabase.git
synced 2026-09-09 03:19:36 +08:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
99 lines
2.9 KiB
TypeScript
99 lines
2.9 KiB
TypeScript
import { screen } from '@testing-library/dom'
|
|
import { mockAnimationsApi } from 'jsdom-testing-mocks'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { IntegrationOverviewTab } from './IntegrationOverviewTab'
|
|
import { customRender } from '@/tests/lib/custom-render'
|
|
import { routerMock } from '@/tests/lib/route-mock'
|
|
|
|
mockAnimationsApi()
|
|
|
|
vi.mock('../Landing/Integrations.constants', () => ({
|
|
INTEGRATIONS: [
|
|
{
|
|
id: 'test-integration',
|
|
name: 'Test Integration',
|
|
requiredExtensions: ['pg_net'],
|
|
},
|
|
],
|
|
}))
|
|
|
|
vi.mock('framer-motion', async (importOriginal) => {
|
|
const actual = (await importOriginal()) as any
|
|
return {
|
|
...actual,
|
|
motion: {
|
|
...actual.motion,
|
|
div: ({ children, ...props }: any) => <div {...props}>{children}</div>,
|
|
},
|
|
}
|
|
})
|
|
|
|
const mockExtensions = vi.fn()
|
|
|
|
vi.mock('@/data/database-extensions/database-extensions-query', () => ({
|
|
useDatabaseExtensionsQuery: () => ({ data: mockExtensions() }),
|
|
}))
|
|
|
|
vi.mock('@/hooks/misc/useSelectedProject', () => ({
|
|
useSelectedProjectQuery: () => ({
|
|
data: { ref: 'default', connectionString: 'postgres://localhost' },
|
|
}),
|
|
useIsOrioleDb: () => false,
|
|
}))
|
|
|
|
vi.mock('common', async (importOriginal) => {
|
|
const actual = (await importOriginal()) as any
|
|
return {
|
|
...actual,
|
|
useParams: () => ({ id: 'test-integration', ref: 'default' }),
|
|
}
|
|
})
|
|
|
|
vi.mock('./MarkdownContent', () => ({
|
|
MarkdownContent: () => null,
|
|
}))
|
|
|
|
vi.mock('../Landing/useIntegrationDetail', () => ({
|
|
useIntegrationDetail: () => ({
|
|
integration: {
|
|
id: 'test-integration',
|
|
name: 'Test Integration',
|
|
requiredExtensions: ['pg_net'],
|
|
missingExtensionsAlert: null,
|
|
},
|
|
}),
|
|
}))
|
|
|
|
describe('IntegrationOverviewTab', () => {
|
|
beforeEach(() => {
|
|
routerMock.setCurrentUrl('/project/default/integrations/test-integration/overview')
|
|
mockExtensions.mockReturnValue([
|
|
{ name: 'pg_net', installed_version: null, default_version: '0.6.0' },
|
|
])
|
|
})
|
|
|
|
it('does not disable actions when hideRequiredExtensionsSection is true and extensions are uninstalled', () => {
|
|
customRender(
|
|
<IntegrationOverviewTab
|
|
hideRequiredExtensionsSection
|
|
actions={<button tabIndex={0}>Enable webhooks</button>}
|
|
/>
|
|
)
|
|
|
|
const actionsArea = screen.getByText('Enable webhooks').closest('[aria-disabled]')
|
|
expect(actionsArea).toHaveAttribute('aria-disabled', 'false')
|
|
expect(actionsArea).not.toHaveClass('opacity-25')
|
|
})
|
|
|
|
it('disables actions when extensions are uninstalled and hideRequiredExtensionsSection is false', () => {
|
|
customRender(
|
|
<IntegrationOverviewTab actions={<button tabIndex={0}>Enable integration</button>} />
|
|
)
|
|
|
|
const actionsArea = screen.getByText('Enable integration').closest('[aria-disabled]')
|
|
expect(actionsArea).toHaveAttribute('aria-disabled', 'true')
|
|
expect(actionsArea).toHaveClass('opacity-25')
|
|
})
|
|
})
|