5 Commits

Author	SHA1	Message	Date
Charis	1987f19d0a	feat(sql-editor): add manual save feature preview (#47745) ... ## What Adds an opt-in **SQL Editor manual save** feature preview that switches the SQL Editor from autosaving every edit to saving only on demand, and hardens the tab-close flow so unsaved edits are handled correctly. ## Changes **Feature preview** - New `sqlEditorManualSave` flag + `UI_PREVIEW_SQL_EDITOR_MANUAL_SAVE` local-storage toggle, wired into the Feature Preview modal with an explanatory panel. - `useIsSqlEditorManualSaveEnabled` gates behavior on both the flag and the user's preview opt-in. **Editor toolbar** - Save button (with `Cmd+S`) next to Run, plus an autosave status indicator showing dirty/saving/saved state and a shortcut to disable autosave (emits a `sql_editor_autosave_disable_clicked` telemetry event). **Discard on close** - Closing a snippet tab with unsaved edits prompts for confirmation and, on confirm, actually discards the local edits and evicts the cached server copy so the snippet reopens clean. **Decouple tab layout from SQL specifics** - Tabs store gains a generic per-type close-handler registry (`registerTabCloseHandler` / `getCloseConfirmation` / `closeTabs`). The SQL editor registers its discard + confirmation behavior from the save coordinator. - Low-level `removeTab`/`removeTabs` (rename/move re-keying, stale cleanup) intentionally do **not** trigger discard. - Adds `statusOnDiscard` lifecycle transition and `clearSnippetContent` store action. ## Testing - `pnpm --filter=studio typecheck` — clean. - Added unit tests for the close-handler registry (fires on single/multi close, skips re-keying/cleanup removals, respects tab type, selects confirmation copy, unregisters cleanly). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a SQL editor manual-save preview with a “Save” button and `Cmd+S`, plus a modal option to disable manual-save/preview. * Added “unsaved changes” tab status indication when manual-save is enabled. * Introduced tab-type-specific close confirmations (shown only when needed). * **Bug Fixes** * In manual-save mode, closing a SQL tab with unsaved edits now clears local snippet content and refreshes it on reopen. * **Tests** * Added coverage for tab close handlers and confirmation behavior. * **Chores** * Added a persisted setting allowlist entry and tracked autosave-disable clicks via telemetry. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-07-09 08:37:38 -04:00
Charis	7c1ea30e43	refactor(studio): extract useSnippetEditor from MonacoEditor (#47500) ... ## What PR 7 of the SQL editor state re-layering stack. Extracts the snippet editing lifecycle out of `MonacoEditor` into a co-located `useSnippetEditor` hook, and consolidates the edit debounce. `useSnippetEditor` owns: - creating the snippet in the store on first edit and routing to its URL (replace vs push for a `?content=` deep link) - writing changes back to the store via `setSql` (with `wasNeverPersisted` → `shouldInvalidate`) - seeding the editor from the `content` param - the read-only determination (`canEditSnippet`) `MonacoEditor` now consumes `{ snippet, disableEdit, handleEditorChange }` and keeps only the editor shell + Monaco action wiring. It sheds the `router`/`profile`/`project`/`params`/store/tabs hooks. `handleEditorChange` was also flattened with an early return. ## Debounce consolidation Previously there were **two 1s debounces in series**: `useSnippetEditor` debounced editor changes before writing to the store, and the save mechanism (`createSaveMechanism`) already debounces persistence. That added latency (up to ~2s to save) and split the "when to persist" timing policy across two layers — at odds with PR 5's design where the scheduler/mechanism owns *when* and dirty state is meant to be immediate. This PR removes the editor-side debounce: edits write to the store synchronously on every change, and the save mechanism's 1s debounce is the sole throttle. Net effects: - the store — and the snippet's dirty status — reflects the latest edit immediately (correct for the future manual-save mode's Save button / nav guard) - save fires ~1s after the *last* keystroke instead of up to ~2s - only the active snippet's own reactive consumers (a lightweight sidebar item) re-render per keystroke; Monaco is uncontrolled (`defaultValue`) so it is unaffected Note: the double-debounce was legacy (the pre-refactor god store had the same `useDebounce(value, 1000)` in MonacoEditor plus a debounced module-load subscribe). ## Notes - Behavior-preserving in outcome — autosave still lands ~1s after typing stops, just with lower latency and immediate store consistency. ## Validation - `pnpm --filter studio typecheck` ✅ - `pnpm exec vitest --run state/sql-editor/` ✅ (110 passed) - lint ✅ (0 errors; no ratcheted-rule regressions) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * SQL editor changes now apply immediately, with unsaved status reflected as soon as you edit. * The editor now keeps the latest snippet details available for saving, improving reliability when using “Save Query.” * **Bug Fixes** * Improved handling for creating and opening snippets from shared links or prefilled content. * Fixed status updates so saved snippets correctly switch to unsaved after edits. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-07-01 15:59:15 -04:00
Charis	5cb81123ae	refactor(studio): move SQL editor save trigger into a scheduler + provider (5/9) (#47316) ... ## What PR 5 of a stacked refactor. Moves *when to save* out of a module-load `subscribe` and into an injectable **scheduler** armed by a headless **provider**, splits the save queue, and adds an unsaved-close warning. ### Scheduler (`sql-editor-save-scheduler.ts`) `createSaveScheduler({ state, saveMechanism, notify, getSaveMode })` owns the save *policy*: - **auto** mode drains the dirty snippet queue as edits land; **manual** mode (the seam for a future opt-in; defaults to `auto`) leaves snippets queued until `requestSave`. Folder saves always drain. - `start()` returns an unsubscribe; `requestSave(id)` is the explicit-save entry. ### Provider (`sql-editor-save-coordinator.tsx`) Headless `SqlEditorSaveCoordinatorProvider` instantiates the mechanism (invalidation via the **React Query client from context**, not the global `getQueryClient`) + scheduler, `start()`s it in an effect (start/stop with the provider), and exposes `requestSave` via `useSqlEditorSaveCoordinator()`. Mounted in `ProjectContext` (under the app's QueryClientProvider). Cmd+S and the SavingIndicator Retry now go through `requestSave`. ### Queue split `needsSaving` (snippets) and `pendingFolderSaves` (folders) are separate queues, drained independently — the old snippet-vs-folder `if/else` is gone. ### Unsaved-close warning A `beforeunload` guard triggers the browser's native "Leave site?" prompt while any snippet's `status !== 'saved'` (failed / in-flight / never-saved). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Improved SQL editor saving with a centralized save flow, including automatic/manual save handling and immediate “Save Query” requests. * Added unsaved-change detection so the app can warn before closing or reloading when edits are still pending. * **Bug Fixes** * Retry actions now use the updated save flow for more reliable re-saving. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-06-25 16:24:04 -04:00
Charis	16526bd6bf	refactor(studio): extract SQL editor save mechanism + model folder lifecycle (4/9) (#47276) ... ## What PR 4 of a stacked refactor of the SQL editor snippet/folder state. It pulls the persistence logic out of the store into an injectable mechanism, and replaces the folder `'new-folder'` id sentinel with an explicit lifecycle — plus a concurrency bug fix that surfaced along the way. ### Save mechanism (`sql-editor-save.ts`) `createSaveMechanism({ state, upsertContent, createSQLSnippetFolder, updateSQLSnippetFolder, invalidate, notify, debounceMs })` → `{ saveSnippet, createFolder, updateFolder }`. The store's subscribe now dispatches to it; *when* to save still lives in the subscribe (the scheduler/provider move is PR 5). Per-id debounce cache lives in the factory closure (no module-global leak). - **`saveSnippet`** reads the live store snippet, guards `isLoadedSnippet` so a content-less snippet can **never PUT an empty body** (directly unit-tested), then builds the payload + drives status transitions + gated invalidation. - **`toast` is injected** as a `Notifier` (new generic DI contract in `lib/notifier.ts`) — the mechanism no longer imports sonner. - **create vs rename are two named-arg functions**, not an `isNew` branch; rollback is deterministic per operation instead of matching on `error.message` text. - **caught errors are `unknown`**, narrowed via the existing `getErrorMessage` util with a generic fallback — no `any`. ### Folder lifecycle (replaces the `NEW_FOLDER_ID` sentinel) - **`FolderStatus`** enum (`new_editing | new_saving | editing | saving | idle`) collapses the persistence and progress axes into one enum — same pattern as `SnippetStatus` — with `isNewFolder` / `isFolderEditing` / `isFolderSaving` predicates. Tagging a folder as new/persisted is now an explicit field, not an id convention. - New placeholders get a **unique local id** (`crypto.randomUUID`); `NEW_FOLDER_ID` is deleted, which also lifts the accidental one-unsaved-folder-at-a-time limit. ### Bug fix: folder-rename rollback race The shared `lastUpdatedFolderName` field let two in-flight renames clobber each other's rollback target (and a shared `finally` could wipe it). Replaced by a **per-folder `previousName`** on `StateSnippetFolder`, so concurrent renames of different folders are isolated. A new test runs two failing renames concurrently and asserts each restores its own previous name. ## Tests `sql-editor-save.test.ts` (mechanism — fakes + fake timers, incl. content-less no-PUT and concurrent-rename isolation) and folder-lifecycle predicate tests. `pnpm --filter studio typecheck` clean; 82 state/sql-editor unit tests pass. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Improved SQL editor folder handling with clearer create, rename, and save states. * Added a more consistent notification flow for successful and failed save actions. * **Bug Fixes** * Improved rollback handling when folder renames fail, helping restore the previous name reliably. * Updated save behavior to better protect against duplicate or out-of-order updates. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-06-25 11:08:26 -04:00
Charis	d5653f1f92	refactor(studio): unify snippet save + persistence into SnippetStatus (3/9) (#47251) ... ## What PR 3 of a stacked refactor of the SQL editor snippet state. Replaces the two overlapping pieces of snippet lifecycle state — the `savingStates` map (`IDLE|UPDATING|UPDATING_FAILED`) and the `isNotSavedInDatabaseYet` boolean — with a single `SnippetStatus` enum. ## Status is attached at the data layer (never absent) - `SnippetStatus` + `SnippetWithContent` now live in `data/content`. The snippet queries attach `status: 'saved'` via a typed `withSavedStatus()` helper, and `upsertContent` returns `SnippetWithContent` so move/rename responses carry status too. - A SQL-typed `getSqlSnippetById`/`useSqlSnippetByIdQuery` returns `SnippetWithContent` (the generic `useContentIdQuery` stays for Reports, which use it). `[id].tsx` loads content with **no casting**. - `'new'` is attached on local creation (`createSqlSnippetSkeletonV2`). ## Behavior Behavior-preserving for the existing auto-save flow (faithful mapping of both old fields, including the replication-lag swallow). One incidental fix: the read-only/saving indicator now also covers a brand-new snippet's first save (previously only re-saves of persisted snippets had distinct saving/failed states in some paths). ## Tests New `sql-editor-lifecycle.test.ts` (29 tests) covering every predicate and transition; existing rules tests updated. `pnpm --filter studio typecheck` clean; 52 state/sql-editor unit tests pass. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Refactor** * Restructured SQL snippet persistence tracking, replacing boolean flags with a comprehensive status system for clearer visibility into save progress. * Enhanced saving indicator UI to reflect accurate snippet save states. * **Tests** * Added test coverage for snippet persistence state transitions and lifecycle scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-06-24 08:56:39 -04:00