lywsvip/supabase
1
0
Fork 0
mirror of https://github.com/supabase/supabase.git synced 2026-07-01 01:25:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Chore/align bucket and object naming validation with storage api (#37854)

Browse Source 
* Align bucket naming validation

* Align folder naming validation

* Remove description
This commit is contained in:
Joshen Lim
2025-08-12 14:01:34 +07:00
committed by GitHub
parent f927998e4e
commit 4418e6df19
4 changed files with 113 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
apps/studio/components/interfaces/Storage/CreateBucketModal.tsx
View File

@@ -39,6 +39,7 @@ import {
} from 'ui'
import { Admonition } from 'ui-patterns/admonition'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import { inverseValidBucketNameRegex, validBucketNameRegex } from './CreateBucketModal.utils'
import { convertFromBytes, convertToBytes } from './StorageSettings/StorageSettings.utils'
export interface CreateBucketModalProps {
@@ -46,29 +47,42 @@ export interface CreateBucketModalProps {
onClose: () => void
}
const FormSchema = z.object({
name: z
.string()
.trim()
.min(1, 'Please provide a name for your bucket')
.regex(
/^[a-z0-9.-]+$/,
'The name of the bucket must only contain lowercase letters, numbers, dots, and hyphens'
)
.refine((value) => !value.endsWith(' '), 'The name of the bucket cannot end with a whitespace')
.refine(
(value) => value !== 'public',
'"public" is a reserved name. Please choose another name'
),
type: z.enum(['STANDARD', 'ANALYTICS']).default('STANDARD'),
public: z.boolean().default(false),
has_file_size_limit: z.boolean().default(false),
formatted_size_limit: z.coerce
.number()
.min(0, 'File size upload limit has to be at least 0')
.default(0),
allowed_mime_types: z.string().trim().default(''),
})
const FormSchema = z
.object({
name: z
.string()
.trim()
.min(1, 'Please provide a name for your bucket')
.max(100, 'Bucket name should be below 100 characters')
.refine(
(value) => !value.endsWith(' '),
'The name of the bucket cannot end with a whitespace'
)
.refine(
(value) => value !== 'public',
'"public" is a reserved name. Please choose another name'
),
type: z.enum(['STANDARD', 'ANALYTICS']).default('STANDARD'),
public: z.boolean().default(false),
has_file_size_limit: z.boolean().default(false),
formatted_size_limit: z.coerce
.number()
.min(0, 'File size upload limit has to be at least 0')
.default(0),
allowed_mime_types: z.string().trim().default(''),
})
.superRefine((data, ctx) => {
if (!validBucketNameRegex.test(data.name)) {
const [match] = data.name.match(inverseValidBucketNameRegex) ?? []
ctx.addIssue({
path: ['name'],
code: z.ZodIssueCode.custom,
message: !!match
? `Bucket name cannot contain the "${match}" character`
: 'Bucket name contains an invalid special character',
})
}
})
export type CreateBucketForm = z.infer<typeof FormSchema>
@@ -182,10 +196,9 @@ const CreateBucketModal = ({ visible, onClose }: CreateBucketModalProps) => {
name="name"
render={({ field }) => (
<FormItemLayout
layout="vertical"
label="Name of bucket"
labelOptional="Buckets cannot be renamed once created."
description="Only lowercase letters, numbers, dots, and hyphens"
layout="vertical"
>
<FormControl_Shadcn_>
<Input_Shadcn_ {...field} placeholder="Enter bucket name" />
@@ -194,12 +207,12 @@ const CreateBucketModal = ({ visible, onClose }: CreateBucketModalProps) => {
)}
/>
<div className="flex flex-col gap-y-2 mt-6">
<div className="flex flex-col gap-y-2 mt-2">
<FormField_Shadcn_
control={form.control}
name="type"
render={({ field }) => (
<FormItemLayout>
<FormItemLayout label="Bucket type">
<FormControl_Shadcn_>
<RadioGroupStacked
id="type"