mirror of
https://github.com/reactos/reactos.git
synced 2026-09-09 02:44:55 +08:00
fbcef39dd6
DebugPrint starts a va_list with va_start and formats from it, but never calls va_end on any path. On the targets ReactOS builds for this happens to be harmless, but it is undefined behaviour and breaks on any ABI where va_end has real work to do. The VIRTIO_DBG_USE_IOPORT block has the same problem in a worse form: it hands the list to RtlStringCbVPrintfA after PrintProcedure has already walked it, so on that configuration the second pass formats from an indeterminate va_list. End the list right after the first consumer and start a fresh one for the second, ending that too. netkvm is listed in media/doc/3rd Party Files.txt, but the entry pins a commit-tree URL rather than a branch, because upstream virtio-win deleted its NDIS5 driver: this copy has no live upstream to send the fix to, and ReactOS has already patched this same file locally. Hence ReactOS rather than virtio-win, and no __REACTOS__ guard - there are none anywhere in this directory. CORE-15841 Reviewed-by: Whindmar Saksit <whindsaks@proton.me> Reviewed-by: Stanislav Motylkov <x86corez@gmail.com> Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org> Signed-off-by: John Rowe <opensource@rowe.lol>