From f3c1d644ec98c85acfe9bd6733ae05e6e34f8e35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Wed, 8 Apr 2026 22:54:15 +0200 Subject: [PATCH] [NTOS:IO] IopCreateArcNames(): Remove unused variable and improve comments This has been forgotten since the split of `IopCreateArcNames()` in commit 6d0861e9ed (r49131). Also, improve comments regarding `ArcHalDeviceName` vs. `ArcBootDeviceName`. --- ntoskrnl/io/iomgr/arcname.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/ntoskrnl/io/iomgr/arcname.c b/ntoskrnl/io/iomgr/arcname.c index 74ed04fe14b..6029e2ea017 100644 --- a/ntoskrnl/io/iomgr/arcname.c +++ b/ntoskrnl/io/iomgr/arcname.c @@ -45,20 +45,20 @@ IopCreateArcNames(IN PLOADER_PARAMETER_BLOCK LoaderBlock) BOOLEAN FoundBoot = FALSE; UNICODE_STRING SystemDevice, LoaderPathNameW, BootDeviceName; PARC_DISK_INFORMATION ArcDiskInfo = LoaderBlock->ArcDiskInformation; - ANSI_STRING ArcSystemString, ArcString, LanmanRedirector, LoaderPathNameA; + ANSI_STRING ArcString, LanmanRedirector, LoaderPathNameA; /* Check if we only have one disk on the machine */ SingleDisk = (ArcDiskInfo->DiskSignatureListHead.Flink->Flink == &ArcDiskInfo->DiskSignatureListHead); - /* Create the global HAL partition name */ + /* Create the firmware system loader / HAL partition global name */ sprintf(Buffer, "\\ArcName\\%s", LoaderBlock->ArcHalDeviceName); RtlInitAnsiString(&ArcString, Buffer); Status = RtlAnsiStringToUnicodeString(&IoArcHalDeviceName, &ArcString, TRUE); if (!NT_SUCCESS(Status)) return Status; - /* Create the global system partition name */ + /* Create the OS boot partition global name */ sprintf(Buffer, "\\ArcName\\%s", LoaderBlock->ArcBootDeviceName); RtlInitAnsiString(&ArcString, Buffer); Status = RtlAnsiStringToUnicodeString(&IoArcBootDeviceName, &ArcString, TRUE); @@ -85,9 +85,6 @@ IopCreateArcNames(IN PLOADER_PARAMETER_BLOCK LoaderBlock) SingleDisk = FALSE; } - /* Build the boot strings */ - RtlInitAnsiString(&ArcSystemString, LoaderBlock->ArcHalDeviceName); - /* If we are doing remote booting */ if (IoRemoteBootClient) {