From df01aa62410923eecb26f43ec853b4b89e1441e1 Mon Sep 17 00:00:00 2001
From: Eric Kohl <eric.kohl@reactos.org>
Date: Tue, 13 Jan 2026 23:30:42 +0100
Subject: [PATCH] [DISKPART] Replace the hardcoded volume type strings

---
 base/system/diskpart/lang/de-DE.rc |  8 ++++++++
 base/system/diskpart/lang/en-US.rc |  8 ++++++++
 base/system/diskpart/lang/it-IT.rc |  8 ++++++++
 base/system/diskpart/lang/pl-PL.rc |  8 ++++++++
 base/system/diskpart/lang/pt-PT.rc |  8 ++++++++
 base/system/diskpart/lang/ro-RO.rc |  8 ++++++++
 base/system/diskpart/lang/ru-RU.rc |  8 ++++++++
 base/system/diskpart/lang/sq-AL.rc |  8 ++++++++
 base/system/diskpart/lang/tr-TR.rc |  8 ++++++++
 base/system/diskpart/lang/zh-CN.rc |  8 ++++++++
 base/system/diskpart/lang/zh-TW.rc |  8 ++++++++
 base/system/diskpart/list.c        | 18 ++++++++++++------
 base/system/diskpart/resource.h    |  5 +++++
 13 files changed, 105 insertions(+), 6 deletions(-)

diff --git a/base/system/diskpart/lang/de-DE.rc b/base/system/diskpart/lang/de-DE.rc
index c76ca5ac47b..9783df357ad 100644
--- a/base/system/diskpart/lang/de-DE.rc
+++ b/base/system/diskpart/lang/de-DE.rc
@@ -347,3 +347,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unbekannt"
     IDS_PARTITION_TYPE_UNUSED "Nicht verwendet"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Wechselmedium"
+    IDS_VOLUME_TYPE_UNKNOWN "Unbekannt"
+END
diff --git a/base/system/diskpart/lang/en-US.rc b/base/system/diskpart/lang/en-US.rc
index 1325756b7ac..ebf644f4dfd 100644
--- a/base/system/diskpart/lang/en-US.rc
+++ b/base/system/diskpart/lang/en-US.rc
@@ -347,3 +347,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/it-IT.rc b/base/system/diskpart/lang/it-IT.rc
index a9a80120b36..d9360a5b1d0 100644
--- a/base/system/diskpart/lang/it-IT.rc
+++ b/base/system/diskpart/lang/it-IT.rc
@@ -354,3 +354,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/pl-PL.rc b/base/system/diskpart/lang/pl-PL.rc
index 8e47adc2267..55aa4d63db5 100644
--- a/base/system/diskpart/lang/pl-PL.rc
+++ b/base/system/diskpart/lang/pl-PL.rc
@@ -347,3 +347,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/pt-PT.rc b/base/system/diskpart/lang/pt-PT.rc
index ed6ca29c91b..7d1d2be61cf 100644
--- a/base/system/diskpart/lang/pt-PT.rc
+++ b/base/system/diskpart/lang/pt-PT.rc
@@ -349,3 +349,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/ro-RO.rc b/base/system/diskpart/lang/ro-RO.rc
index b4762fbe9ae..3d4b9a0530a 100644
--- a/base/system/diskpart/lang/ro-RO.rc
+++ b/base/system/diskpart/lang/ro-RO.rc
@@ -355,3 +355,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/ru-RU.rc b/base/system/diskpart/lang/ru-RU.rc
index 1572d6a3c92..0d0adb6cb3a 100644
--- a/base/system/diskpart/lang/ru-RU.rc
+++ b/base/system/diskpart/lang/ru-RU.rc
@@ -349,3 +349,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/sq-AL.rc b/base/system/diskpart/lang/sq-AL.rc
index 6a0e9786714..bff7f706cdd 100644
--- a/base/system/diskpart/lang/sq-AL.rc
+++ b/base/system/diskpart/lang/sq-AL.rc
@@ -351,3 +351,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/tr-TR.rc b/base/system/diskpart/lang/tr-TR.rc
index f1eeffdb105..9a178d0bf80 100644
--- a/base/system/diskpart/lang/tr-TR.rc
+++ b/base/system/diskpart/lang/tr-TR.rc
@@ -357,3 +357,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/zh-CN.rc b/base/system/diskpart/lang/zh-CN.rc
index 8b27596b255..7dc85051eaa 100644
--- a/base/system/diskpart/lang/zh-CN.rc
+++ b/base/system/diskpart/lang/zh-CN.rc
@@ -356,3 +356,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/lang/zh-TW.rc b/base/system/diskpart/lang/zh-TW.rc
index ce4f6fda0fa..6ef9db14fbd 100644
--- a/base/system/diskpart/lang/zh-TW.rc
+++ b/base/system/diskpart/lang/zh-TW.rc
@@ -356,3 +356,11 @@ BEGIN
     IDS_PARTITION_TYPE_UNKNOWN "Unknown"
     IDS_PARTITION_TYPE_UNUSED "Unused"
 END
+
+STRINGTABLE
+BEGIN
+    IDS_VOLUME_TYPE_DVD "DVD"
+    IDS_VOLUME_TYPE_PARTITION "Partition"
+    IDS_VOLUME_TYPE_REMOVABLE "Removable"
+    IDS_VOLUME_TYPE_UNKNOWN "Unknown"
+END
diff --git a/base/system/diskpart/list.c b/base/system/diskpart/list.c
index db9bcc44105..67cbccc21d2 100644
--- a/base/system/diskpart/list.c
+++ b/base/system/diskpart/list.c
@@ -489,7 +489,8 @@ PrintVolume(
 {
     ULONGLONG VolumeSize;
     PWSTR pszSizeUnit;
-    PWSTR pszVolumeType;
+    INT nVolumeType;
+    WCHAR szVolumeTypeBuffer[30];
     WCHAR szInfoBuffer[16];
 
     VolumeSize = VolumeEntry->Size.QuadPart;
@@ -517,20 +518,25 @@ PrintVolume(
     switch (VolumeEntry->VolumeType)
     {
         case VOLUME_TYPE_CDROM:
-            pszVolumeType = L"DVD";
+            nVolumeType = IDS_VOLUME_TYPE_DVD;
             break;
+
         case VOLUME_TYPE_PARTITION:
-            pszVolumeType = L"Partition";
+            nVolumeType = IDS_VOLUME_TYPE_PARTITION;
             break;
+
         case VOLUME_TYPE_REMOVABLE:
-            pszVolumeType = L"Removable";
+            nVolumeType = IDS_VOLUME_TYPE_REMOVABLE;
             break;
+
         case VOLUME_TYPE_UNKNOWN:
         default:
-            pszVolumeType = L"Unknown";
+            nVolumeType = IDS_VOLUME_TYPE_UNKNOWN;
             break;
     }
 
+    LoadStringW(GetModuleHandle(NULL), nVolumeType, szVolumeTypeBuffer, ARRAYSIZE(szVolumeTypeBuffer));
+
     szInfoBuffer[0] = UNICODE_NULL;
     if (VolumeEntry->IsSystem)
         LoadStringW(GetModuleHandle(NULL), IDS_INFO_SYSTEM, szInfoBuffer, ARRAYSIZE(szInfoBuffer));
@@ -543,7 +549,7 @@ PrintVolume(
                  VolumeEntry->DriveLetter,
                  (VolumeEntry->pszLabel) ? VolumeEntry->pszLabel : L"",
                  (VolumeEntry->pszFilesystem) ? VolumeEntry->pszFilesystem : L"",
-                 pszVolumeType,
+                 szVolumeTypeBuffer,
                  VolumeSize, pszSizeUnit,
                  L"",
                  szInfoBuffer);
diff --git a/base/system/diskpart/resource.h b/base/system/diskpart/resource.h
index d80528b7f9e..ef8c947ff5b 100644
--- a/base/system/diskpart/resource.h
+++ b/base/system/diskpart/resource.h
@@ -263,3 +263,8 @@
 #define IDS_PARTITION_TYPE_SYSTEM     5204
 #define IDS_PARTITION_TYPE_UNKNOWN    5205
 #define IDS_PARTITION_TYPE_UNUSED     5206
+
+#define IDS_VOLUME_TYPE_DVD           5250
+#define IDS_VOLUME_TYPE_PARTITION     5251
+#define IDS_VOLUME_TYPE_REMOVABLE     5252
+#define IDS_VOLUME_TYPE_UNKNOWN       5253