From d4ffcf81bee9271ccd69d66362690bec01d1ecd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?= Date: Fri, 2 Jan 2026 22:04:20 +0100 Subject: [PATCH] [BOOTVID][NTOS:INBV] Improve SAL annotations for *BufferToScreenBlt() and *ScreenToBufferBlt() --- drivers/base/bootvid/arm/bootvid.c | 2 +- drivers/base/bootvid/i386/pc/vga.c | 2 +- drivers/base/bootvid/i386/pc98/bootvid.c | 2 +- drivers/base/bootvid/i386/xbox/bootvid.c | 2 +- ntoskrnl/inbv/inbv.c | 4 ++-- ntoskrnl/include/internal/inbv.h | 4 ++-- sdk/include/reactos/drivers/bootvid/bootvid.h | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/base/bootvid/arm/bootvid.c b/drivers/base/bootvid/arm/bootvid.c index fa374726b18..0ad4d5fce57 100644 --- a/drivers/base/bootvid/arm/bootvid.c +++ b/drivers/base/bootvid/arm/bootvid.c @@ -282,7 +282,7 @@ VidCleanUp(VOID) VOID NTAPI VidScreenToBufferBlt( - _Out_writes_bytes_(Delta * Height) PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Width, diff --git a/drivers/base/bootvid/i386/pc/vga.c b/drivers/base/bootvid/i386/pc/vga.c index 568c0cb3a05..a7b771f23df 100644 --- a/drivers/base/bootvid/i386/pc/vga.c +++ b/drivers/base/bootvid/i386/pc/vga.c @@ -330,7 +330,7 @@ VidCleanUp(VOID) VOID NTAPI VidScreenToBufferBlt( - _Out_writes_bytes_(Delta * Height) PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Width, diff --git a/drivers/base/bootvid/i386/pc98/bootvid.c b/drivers/base/bootvid/i386/pc98/bootvid.c index 383e84757a1..ab2d6c84759 100644 --- a/drivers/base/bootvid/i386/pc98/bootvid.c +++ b/drivers/base/bootvid/i386/pc98/bootvid.c @@ -417,7 +417,7 @@ ResetDisplay( VOID NTAPI VidScreenToBufferBlt( - _Out_writes_bytes_(Delta * Height) PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Width, diff --git a/drivers/base/bootvid/i386/xbox/bootvid.c b/drivers/base/bootvid/i386/xbox/bootvid.c index 93690b7aea4..70af09f66f2 100644 --- a/drivers/base/bootvid/i386/xbox/bootvid.c +++ b/drivers/base/bootvid/i386/xbox/bootvid.c @@ -401,7 +401,7 @@ VidSolidColorFill( VOID NTAPI VidScreenToBufferBlt( - _Out_writes_bytes_(Delta * Height) PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Width, diff --git a/ntoskrnl/inbv/inbv.c b/ntoskrnl/inbv/inbv.c index 1cfd5efefaa..3ead8a660db 100644 --- a/ntoskrnl/inbv/inbv.c +++ b/ntoskrnl/inbv/inbv.c @@ -557,7 +557,7 @@ InbvBitBlt( VOID NTAPI InbvBufferToScreenBlt( - _In_ PUCHAR Buffer, + _In_reads_bytes_(Delta * Height) PUCHAR Buffer, _In_ ULONG X, _In_ ULONG Y, _In_ ULONG Width, @@ -576,7 +576,7 @@ InbvBufferToScreenBlt( VOID NTAPI InbvScreenToBufferBlt( - _Out_ PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG X, _In_ ULONG Y, _In_ ULONG Width, diff --git a/ntoskrnl/include/internal/inbv.h b/ntoskrnl/include/internal/inbv.h index 31a5e85e561..303646c2279 100644 --- a/ntoskrnl/include/internal/inbv.h +++ b/ntoskrnl/include/internal/inbv.h @@ -56,7 +56,7 @@ InbvBitBlt( VOID NTAPI InbvBufferToScreenBlt( - _In_ PUCHAR Buffer, + _In_reads_bytes_(Delta * Height) PUCHAR Buffer, _In_ ULONG X, _In_ ULONG Y, _In_ ULONG Width, @@ -67,7 +67,7 @@ InbvBufferToScreenBlt( VOID NTAPI InbvScreenToBufferBlt( - _Out_ PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG X, _In_ ULONG Y, _In_ ULONG Width, diff --git a/sdk/include/reactos/drivers/bootvid/bootvid.h b/sdk/include/reactos/drivers/bootvid/bootvid.h index 8a51b3cf76c..45f975232fd 100644 --- a/sdk/include/reactos/drivers/bootvid/bootvid.h +++ b/sdk/include/reactos/drivers/bootvid/bootvid.h @@ -72,7 +72,7 @@ VidBufferToScreenBlt( VOID NTAPI VidScreenToBufferBlt( - _Out_writes_bytes_(Delta * Height) PUCHAR Buffer, + _Out_writes_bytes_all_(Delta * Height) PUCHAR Buffer, _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Width,