From c1d0d409e7c2dfea17f83272c1332936967dffa5 Mon Sep 17 00:00:00 2001 From: Serge Gautherie Date: Fri, 12 Jan 2018 06:30:53 +0100 Subject: [PATCH] [FREELDR] PcMemGetBiosMemoryMap(): Add a default handling of entry with "EA.ErrorLog = 1". CORE-14150 This FIXME is meant as a reminder/help to actually use this data. --- boot/freeldr/freeldr/arch/i386/pcmem.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/boot/freeldr/freeldr/arch/i386/pcmem.c b/boot/freeldr/freeldr/arch/i386/pcmem.c index b6024ff73ac..28d6e06e4c1 100644 --- a/boot/freeldr/freeldr/arch/i386/pcmem.c +++ b/boot/freeldr/freeldr/arch/i386/pcmem.c @@ -351,6 +351,18 @@ PcMemGetBiosMemoryMap(PFREELDR_MEMORY_DESCRIPTOR MemoryMap, ULONG MaxMemoryMapSi TRACE("Type: 0x%lx\n", PcBiosMemoryMap[PcBiosMapCount].Type); TRACE("ExtendedAttributesAsULONG: 0x%08lx\n", PcBiosMemoryMap[PcBiosMapCount].ExtendedAttributesAsULONG); + if (PcBiosMemoryMap[PcBiosMapCount].ExtendedAttributes.ErrorLog == 1) + { + FIXME("EA.ErrorLog = 1. Please report this to CORE-14150. " + "(PcBiosMapCount = %lu, BaseAddress = 0x%llx, Length = 0x%llx, Type = 0x%lx, ExtendedAttributesAsULONG = 0x%08lx)\n", + PcBiosMapCount, + PcBiosMemoryMap[PcBiosMapCount].BaseAddress, + PcBiosMemoryMap[PcBiosMapCount].Length, + PcBiosMemoryMap[PcBiosMapCount].Type, + PcBiosMemoryMap[PcBiosMapCount].ExtendedAttributesAsULONG); + // NotWantedForPublicBuilds: ASSERTMSG("EA.ErrorLog = 1. Check/Report then CONTinue.", FALSE); + } + if (PcBiosMemoryMap[PcBiosMapCount].Length == 0) { TRACE("Discard empty range. (would-be-PcBiosMapCount = %lu, BaseAddress = 0x%llx, Length = 0)\n",