From be87e0099f59bed2842d3b64db6d112d57cf332b Mon Sep 17 00:00:00 2001 From: Mohammad Amin Mollazadeh Date: Mon, 28 Apr 2025 23:14:58 +0330 Subject: [PATCH] [SHELL32] Return correct CSIDL for "Network Connections" menu item (#7938) Fixes erroneous addition of "Properties" item into its context menu. - Addendum to 0241b5c4e93 and 5aaead3fdb1. CORE-20152 - Also remove FIXME for CORE-19477 which is fixed now. CORE-20151 --- dll/win32/shell32/shellmenu/CStartMenu.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dll/win32/shell32/shellmenu/CStartMenu.cpp b/dll/win32/shell32/shellmenu/CStartMenu.cpp index 218f18919a2..478982fa3bd 100644 --- a/dll/win32/shell32/shellmenu/CStartMenu.cpp +++ b/dll/win32/shell32/shellmenu/CStartMenu.cpp @@ -357,7 +357,7 @@ private: case IDM_MYDOCUMENTS: return CSIDL_MYDOCUMENTS; case IDM_MYPICTURES: return CSIDL_MYPICTURES; case IDM_CONTROLPANEL: return CSIDL_CONTROLS; - case IDM_NETWORKCONNECTIONS: return CSIDL_NETWORK; + case IDM_NETWORKCONNECTIONS: return CSIDL_CONNECTIONS; case IDM_PRINTERSANDFAXES: return CSIDL_PRINTERS; default: return 0; } @@ -371,9 +371,6 @@ private: TRACE("csidl: 0x%X\n", csidl); - if (csidl == CSIDL_CONTROLS || csidl == CSIDL_NETWORK || csidl == CSIDL_PRINTERS) - FIXME("This CSIDL %d wrongly opens My Computer. CORE-19477\n", csidl); - CComHeapPtr pidl; SHGetSpecialFolderLocation(NULL, csidl, &pidl);