From ba22ca771dfd30113089500266fde7d317bb2af2 Mon Sep 17 00:00:00 2001 From: Stefan Ginsberg Date: Wed, 24 Sep 2008 17:11:35 +0000 Subject: [PATCH] - IoFlushAdapterBuffers: "AdapterObject" is not an optional parameter, it is vital to identify the DMA adapter. Remove the check which confused Coverity and ASSERTify this instead. - Fix for Coverity error CID: 155 svn path=/trunk/; revision=36489 --- reactos/hal/halx86/generic/dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/reactos/hal/halx86/generic/dma.c b/reactos/hal/halx86/generic/dma.c index efd53f430d6..293a2771bcf 100644 --- a/reactos/hal/halx86/generic/dma.c +++ b/reactos/hal/halx86/generic/dma.c @@ -1569,9 +1569,11 @@ IoFlushAdapterBuffers( PHYSICAL_ADDRESS PhysicalAddress; PPFN_NUMBER MdlPagesPtr; + /* Sanity checks */ ASSERT_IRQL_LESS_OR_EQUAL(DISPATCH_LEVEL); + ASSERT(AdapterObject); - if (AdapterObject != NULL && !AdapterObject->MasterDevice) + if (!AdapterObject->MasterDevice) { /* Mask out (disable) the DMA channel. */ if (AdapterObject->AdapterNumber == 1)