[CMAKE] Remove obsolete 'GCC_VERSION' checks (#2962)

following upgrade to RosBE 2.2.0 support and GCC 8.4.

modules/rosapps/applications/devutils/createspec/CMakeLists.txt

@@ -1,5 +1,5 @@
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-stringop-overflow")
 endif()
 

modules/rostests/winetests/advpack/CMakeLists.txt

@@ -1,7 +1,7 @@
 
 add_definitions(-DUSE_WINE_TODOS)
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/fusion/CMakeLists.txt

@@ -1,7 +1,7 @@
 
 add_definitions(-DUSE_WINE_TODOS)
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/msi/CMakeLists.txt

@@ -8,7 +8,7 @@ if(MSVC_IDE)
     include_directories($<TARGET_FILE_DIR:custom>)
 endif()
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/msvcrt/CMakeLists.txt

@@ -4,7 +4,7 @@ add_definitions(
     -D_CRT_NONSTDC_NO_DEPRECATE
     -D__msvcrt_ulong=ULONG)
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-stringop-truncation")
 endif()
 

modules/rostests/winetests/services/CMakeLists.txt

@@ -1,5 +1,5 @@
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/setupapi/CMakeLists.txt

@@ -1,5 +1,5 @@
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/shell32/CMakeLists.txt

@@ -3,7 +3,7 @@ add_definitions(-DWINETEST_USE_DBGSTR_LONGLONG)
 
 remove_definitions(-DWINVER=0x502 -D_WIN32_IE=0x600 -D_WIN32_WINNT=0x502)
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/user32/CMakeLists.txt

@@ -5,7 +5,7 @@ add_definitions(-DWINVER=0x602 -D_WIN32_WINNT=0x602)
 if(MSVC)
     # Disable warning C4477 (printf format warnings)
     add_compile_flags("/wd4477")
-elseif(GCC AND GCC_VERSION VERSION_GREATER 7)
+elseif(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()
 

modules/rostests/winetests/version/CMakeLists.txt

@@ -1,7 +1,7 @@
 
 add_definitions(-DUSE_WINE_TODOS)
 
-if(GCC AND GCC_VERSION VERSION_GREATER 7)
+if(GCC)
     add_compile_flags("-Wno-format-overflow")
 endif()